Subset::validateValue() - Code Metrics - Inspection of "Fix #117 issue, InRange SRP violation" - yiisoft/validator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#119)

unknown

created 2021-03-01 18:04 UTC

Subset::validateValue() A

↳ Parent: Subset

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3.1406

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	3
nop	2
dl	0
loc	14
ccs	6
cts	8
cp	0.75
crap	3.1406
rs	10

<?php

namespace Yiisoft\Validator\Rule;

use Yiisoft\Arrays\ArrayHelper;
use Yiisoft\Validator\Result;
use Yiisoft\Validator\Rule;
use Yiisoft\Validator\ValidationContext;

class Subset extends Rule
{
    /**
     * @var iterable
     */
    private iterable $range;
    /**
     * @var bool whether the comparison is strict (both type and value must be the same)
     */
    private bool $strict = false;

    private string $iterableMessage = 'Value must be iterable';

    private string $subsetMessage = 'Value must be subset of...';

    public function __construct(iterable $range)
    {
        $this->range = $range;
    }

    protected function validateValue($value, ValidationContext $context = null): Result
    {
        $result = new Result();

        if (!is_iterable($value)) {
            $result->addError($this->formatMessage($this->iterableMessage));
            return $result;
        }

        if (!ArrayHelper::isSubset($value, $this->range, $this->strict)) {
            $result->addError($this->formatMessage($this->subsetMessage));
        }

        return $result;
    }

    public function strict(): self
    {
        $new = clone $this;
        $new->strict = true;
        return $new;
    }

    public function getOptions(): array
    {
        return array_merge(
            parent::getOptions(),
            [
                'iterableMessage' => $this->formatMessage($this->iterableMessage),
                'subsetMessage' => $this->formatMessage($this->subsetMessage),
                'range' => $this->range,
                'strict' => $this->strict
            ],
        );
    }
}


1		<?php
2
3		namespace Yiisoft\Validator\Rule;
4
5		use Yiisoft\Arrays\ArrayHelper;
6		use Yiisoft\Validator\Result;
7		use Yiisoft\Validator\Rule;
8		use Yiisoft\Validator\ValidationContext;
9
10		class Subset extends Rule
11		{
12		/**
13		* @var iterable
14		*/
15		private iterable $range;
16		/**
17		* @var bool whether the comparison is strict (both type and value must be the same)
18		*/
19		private bool $strict = false;
20
21		private string $iterableMessage = 'Value must be iterable';
22
23		private string $subsetMessage = 'Value must be subset of...';
24
25	4	public function __construct(iterable $range)
26		{
27	4	$this->range = $range;
28	4	}
29
30	3	protected function validateValue($value, ValidationContext $context = null): Result
31		{
32	3	$result = new Result();
33
34	3	if (!is_iterable($value)) {
35		$result->addError($this->formatMessage($this->iterableMessage));
36		return $result;
37		}
38
39	3	if (!ArrayHelper::isSubset($value, $this->range, $this->strict)) {
40	1	$result->addError($this->formatMessage($this->subsetMessage));
41		}
42
43	3	return $result;
44		}
45
46		public function strict(): self
47		{
48		$new = clone $this;
49		$new->strict = true;
50		return $new;
51		}
52
53		public function getOptions(): array
54		{
55		return array_merge(
56		parent::getOptions(),
57		[
58		'iterableMessage' => $this->formatMessage($this->iterableMessage),
59		'subsetMessage' => $this->formatMessage($this->subsetMessage),
60		'range' => $this->range,
61		'strict' => $this->strict
62		],
63		);
64		}
65		}
66

yiisoft / validator

Pull Request — master (#119)

Subset::validateValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like