Yiisoft\Validator\Tests\Rule\Base\SkipOnErrorTestTrait::testSkipOnErrorInternal()

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    private function testSkipOnErrorInternal(
        SkipOnErrorInterface $nonSkippingRule,
        SkipOnErrorInterface $skippingRule
    ): void {
        $this->assertFalse($nonSkippingRule->shouldSkipOnError());

It seems like assertFalse() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $new = $nonSkippingRule->skipOnError(true);
        $this->assertFalse($nonSkippingRule->shouldSkipOnError());
        $this->assertTrue($new->shouldSkipOnError());

It seems like assertTrue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->assertNotSame($nonSkippingRule, $new);

It seems like assertNotSame() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->assertTrue($skippingRule->shouldSkipOnError());

        $new = $skippingRule->skipOnError(false);
        $this->assertTrue($skippingRule->shouldSkipOnError());
        $this->assertFalse($new->shouldSkipOnError());
        $this->assertNotSame($skippingRule, $new);
    }