SessionCurrentIdentityStorage::get() - Code Metrics - Inspection of "Split user" - yiisoft/user - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#24)

by Sergei

created 2021-02-20 14:46 UTC

SessionCurrentIdentityStorage::get() B

↳ Parent: SessionCurrentIdentityStorage

Complexity

Conditions	10
Paths	7

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	14
c	1
b	0
f	0
nc	7
nop	0
dl	0
loc	26
rs	7.6666

How to fix Complexity

<?php

declare(strict_types=1);

namespace Yiisoft\User\CurrentIdentity;

use Yiisoft\Session\SessionInterface;

final class SessionCurrentIdentityStorage implements CurrentIdentityStorageInterface
{
    private const SESSION_AUTH_ID = '__auth_id';
    private const SESSION_AUTH_EXPIRE = '__auth_expire';
    private const SESSION_AUTH_ABSOLUTE_EXPIRE = '__auth_absolute_expire';

    /**
     * @var int|null the number of seconds in which the user will be logged out automatically in case of
     * remaining inactive. If this property is not set, the user will be logged out after
     * the current session expires.
     */
    private ?int $authTimeout = null;

    /**
     * @var int|null the number of seconds in which the user will be logged out automatically
     * regardless of activity.
     */
    private ?int $absoluteAuthTimeout = null;

    private SessionInterface $session;

    public function __construct(SessionInterface $session)
    {
        $this->session = $session;
    }

    public function setAuthTimeout(int $timeout = null): self
    {
        $this->authTimeout = $timeout;
        return $this;
    }

    public function setAbsoluteAuthTimeout(int $timeout = null): self
    {
        $this->absoluteAuthTimeout = $timeout;
        return $this;
    }

    public function get(): ?string
    {
        /** @var mixed $id */
        $id = $this->session->get(self::SESSION_AUTH_ID);

        if (
            $id !== null &&
            ($this->authTimeout !== null || $this->absoluteAuthTimeout !== null)
        ) {
            $expire = $this->getExpire();
            $expireAbsolute = $this->getExpireAbsoulte();

            if (
                ($expire !== null && $expire < time()) ||
                ($expireAbsolute !== null && $expireAbsolute < time())
            ) {
                $this->clear();
                return null;
            }

            if ($this->authTimeout !== null) {
                $this->session->set(self::SESSION_AUTH_EXPIRE, time() + $this->authTimeout);
            }
        }

        return $id === null ? null : (string)$id;
    }

    private function getExpire(): ?int
    {
        /** @var mixed $expire */
        $expire = $this->authTimeout !== null
            ? $this->session->get(self::SESSION_AUTH_EXPIRE)
            : null;
        return $expire !== null ? (int)$expire : null;
    }

    private function getExpireAbsoulte(): ?int
    {
        /** @var mixed $expire */
        $expire = $this->absoluteAuthTimeout !== null
            ? $this->session->get(self::SESSION_AUTH_ABSOLUTE_EXPIRE)
            : null;
        if ($expire !== null) {
            $expire = (int)$expire;
        }
        return $expire !== null ? (int)$expire : null;
    }

    public function set(string $id): void
    {
        $this->switchId($id);
    }

    public function clear(): void
    {
        $this->switchId(null);
    }

    private function switchId(?string $id): void
    {
        $this->session->regenerateID();

        $this->session->remove(self::SESSION_AUTH_ID);
        $this->session->remove(self::SESSION_AUTH_EXPIRE);

        if ($id === null) {
            return;
        }

        $this->session->set(self::SESSION_AUTH_ID, $id);
        if ($this->authTimeout !== null) {
            $this->session->set(self::SESSION_AUTH_EXPIRE, time() + $this->authTimeout);
        }
        if ($this->absoluteAuthTimeout !== null) {
            $this->session->set(self::SESSION_AUTH_ABSOLUTE_EXPIRE, time() + $this->absoluteAuthTimeout);
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\User\CurrentIdentity;
6
7			use Yiisoft\Session\SessionInterface;
8
9			final class SessionCurrentIdentityStorage implements CurrentIdentityStorageInterface
10			{
11			private const SESSION_AUTH_ID = '__auth_id';
12			private const SESSION_AUTH_EXPIRE = '__auth_expire';
13			private const SESSION_AUTH_ABSOLUTE_EXPIRE = '__auth_absolute_expire';
14
15			/**
16			* @var int\|null the number of seconds in which the user will be logged out automatically in case of
17			* remaining inactive. If this property is not set, the user will be logged out after
18			* the current session expires.
19			*/
20			private ?int $authTimeout = null;
21
22			/**
23			* @var int\|null the number of seconds in which the user will be logged out automatically
24			* regardless of activity.
25			*/
26			private ?int $absoluteAuthTimeout = null;
27
28			private SessionInterface $session;
29
30			public function __construct(SessionInterface $session)
31			{
32			$this->session = $session;
33			}
34
35			public function setAuthTimeout(int $timeout = null): self
36			{
37			$this->authTimeout = $timeout;
38			return $this;
39			}
40
41			public function setAbsoluteAuthTimeout(int $timeout = null): self
42			{
43			$this->absoluteAuthTimeout = $timeout;
44			return $this;
45			}
46
47			public function get(): ?string
48			{
49			/** @var mixed $id */
50			$id = $this->session->get(self::SESSION_AUTH_ID);
51
52			if (
53			$id !== null &&
54			($this->authTimeout !== null \|\| $this->absoluteAuthTimeout !== null)
55			) {
56			$expire = $this->getExpire();
57			$expireAbsolute = $this->getExpireAbsoulte();
58
59			if (
60			($expire !== null && $expire < time()) \|\|
61			($expireAbsolute !== null && $expireAbsolute < time())
62			) {
63			$this->clear();
64			return null;
65			}
66
67			if ($this->authTimeout !== null) {
68			$this->session->set(self::SESSION_AUTH_EXPIRE, time() + $this->authTimeout);
69			}
70			}
71
72			return $id === null ? null : (string)$id;
73			}
74
75			private function getExpire(): ?int
76			{
77			/** @var mixed $expire */
78			$expire = $this->authTimeout !== null
79			? $this->session->get(self::SESSION_AUTH_EXPIRE)
80			: null;
81			return $expire !== null ? (int)$expire : null;
82			}
83
84			private function getExpireAbsoulte(): ?int
85			{
86			/** @var mixed $expire */
87			$expire = $this->absoluteAuthTimeout !== null
88			? $this->session->get(self::SESSION_AUTH_ABSOLUTE_EXPIRE)
89			: null;
90			if ($expire !== null) {
91			$expire = (int)$expire;
92			}
93			return $expire !== null ? (int)$expire : null;
94			}
95
96			public function set(string $id): void
97			{
98			$this->switchId($id);
99			}
100
101			public function clear(): void
102			{
103			$this->switchId(null);
104			}
105
106			private function switchId(?string $id): void
107			{
108			$this->session->regenerateID();
109
110			$this->session->remove(self::SESSION_AUTH_ID);
111			$this->session->remove(self::SESSION_AUTH_EXPIRE);
112
113			if ($id === null) {
114			return;
115			}
116
117			$this->session->set(self::SESSION_AUTH_ID, $id);
118			if ($this->authTimeout !== null) {
119			$this->session->set(self::SESSION_AUTH_EXPIRE, time() + $this->authTimeout);
120			}
121			if ($this->absoluteAuthTimeout !== null) {
122			$this->session->set(self::SESSION_AUTH_ABSOLUTE_EXPIRE, time() + $this->absoluteAuthTimeout);
123			}
124			}
125			}
126

yiisoft / user

Pull Request — master (#24)

SessionCurrentIdentityStorage::get() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like