Yiisoft\Test\Support\PHPUnitAssertTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	normalizeLineEndings()	0	5	1
A	assertEqualStringsIgnoringLineEndings()	0	9	1
A	assertStringContainsStringIgnoringLineEndings()	0	9	1

<?php

declare(strict_types=1);

namespace Yiisoft\Test\Support;

trait PHPUnitAssertTrait
{
    public function assertEqualStringsIgnoringLineEndings(
        string $expected,
        string $actual,
        string $message = ''
    ): void {
        $expected = self::normalizeLineEndings($expected);

The method Yiisoft\Test\Support\PHPUnitAssertTrait::normalizeLineEndings() is not static, but was called statically.

        $actual = self::normalizeLineEndings($actual);

        $this->assertEquals($expected, $actual, $message);

It seems like assertEquals() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function assertStringContainsStringIgnoringLineEndings(
        string $needle,
        string $haystack,
        string $message = ''
    ): void {
        $needle = self::normalizeLineEndings($needle);

The method Yiisoft\Test\Support\PHPUnitAssertTrait::normalizeLineEndings() is not static, but was called statically.

        $haystack = self::normalizeLineEndings($haystack);

        $this->assertStringContainsString($needle, $haystack, $message);

The method assertStringContainsString() does not exist on Yiisoft\Test\Support\PHPUnitAssertTrait. Did you maybe mean assertStringContainsStringIgnoringLineEndings()?

    }

    private function normalizeLineEndings(string $value): string
    {
        return strtr($value, [
            "\r\n" => "\n",
            "\r" => "\n",
        ]);
    }
}