Yiisoft\Strings\NumericHelper

Complexity

Total Complexity

9

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	toOrdinal()	0	22	7
A	normalize()	0	7	2

<?php

namespace Yiisoft\Strings;

/**
 * Provides static methods to work with numeric strings.
 */
final class NumericHelper
{
    /**
     * Converts number to its ordinal English form. For example, converts 13 to 13th, 2 to 2nd etc.
     * @param int|float|string $value The number to get its ordinal value.
     * @return string
     */
    public static function toOrdinal($value): string
    {
        if (!is_numeric($value)) {
            throw new \InvalidArgumentException('Value must be numeric.');
        }

        if (fmod($value, 1) !== 0.00) {

It seems like $value can also be of type string; however, parameter $x of fmod() does only seem to accept double, maybe add an additional type check?

            return $value;
        }

        if (\in_array($value % 100, [11, 12, 13], true)) {
            return $value . 'th';
        }
        switch ($value % 10) {
            case 1:
                return $value . 'st';
            case 2:
                return $value . 'nd';
            case 3:
                return $value . 'rd';
            default:
                return $value . 'th';
        }
    }

    /**
     * Returns string representation of a number value without thousands separators and with dot as decimal separator.
     * @param int|float|string $value
     * @return string
     */
    public static function normalize($value): string
    {
        if (!is_scalar($value)) {

The condition is_scalar($value) is always true.

            throw new \InvalidArgumentException('Value must be scalar.');
        }
        $value = str_replace([" ", ","], ["", "."], $value);
        return preg_replace('/\.(?=.*\.)/', '', $value);
    }
}