PasswordHasherTest::testPasswordHash() - Code Metrics - Inspection of "Fixed TypeError: password_hash() expects parameter..." - yiisoft/security - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6b04c6...8a1192 )

by Alexander

created 2019-12-03 18:33 UTC

PasswordHasherTest::testPasswordHash() A

↳ Parent: PasswordHasherTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	11
rs	10
cc	1
nc	1
nop	0

<?php

namespace Yiisoft\Security\Tests;

use PHPUnit\Framework\TestCase;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Yiisoft\Security\PasswordHasher;

class PasswordHasherTest extends TestCase
{
    public function testPasswordHashWithDefaults(): void
    {
        $password = new PasswordHasher();

        $secret = 'secret';
        $hash = $password->hash($secret);

        $this->assertTrue($password->validate($secret, $hash));
        $this->assertFalse($password->validate('test', $hash));
    }

    public function testPasswordHash(): void
    {
        $password = new PasswordHasher(PASSWORD_BCRYPT, [
            // minimum blowfish's value is enough for tests
            'cost' => 4,
        ]);

        $secret = 'secret';
        $hash = $password->hash($secret);
        $this->assertTrue($password->validate($secret, $hash));
        $this->assertFalse($password->validate('test', $hash));
    }

    public function testValidateEmptyPasswordException()
    {
        $this->expectException(\InvalidArgumentException::class);

        $password = new PasswordHasher();
        $password->validate('', 'test');
    }

    /**
     * In PHP 7.4 password hashing algorithm identifiers are now nullable strings rather than integers.
     */
    public function testAlgorithmString()
    {
        $password = new PasswordHasher('test');

        $this->assertTrue(true);
    }
}


1			<?php
2
3			namespace Yiisoft\Security\Tests;
4
5			use PHPUnit\Framework\TestCase;
			0 ignored issues – show Bug introduced 2019-08-16 23:28 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Yiisoft\Security\Tests\TestCase`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6			use Yiisoft\Security\PasswordHasher;
7
8			class PasswordHasherTest extends TestCase
9			{
10			public function testPasswordHashWithDefaults(): void
11			{
12			$password = new PasswordHasher();
13
14			$secret = 'secret';
15			$hash = $password->hash($secret);
16
17			$this->assertTrue($password->validate($secret, $hash));
18			$this->assertFalse($password->validate('test', $hash));
19			}
20
21			public function testPasswordHash(): void
22			{
23			$password = new PasswordHasher(PASSWORD_BCRYPT, [
24			// minimum blowfish's value is enough for tests
25			'cost' => 4,
26			]);
27
28			$secret = 'secret';
29			$hash = $password->hash($secret);
30			$this->assertTrue($password->validate($secret, $hash));
31			$this->assertFalse($password->validate('test', $hash));
32			}
33
34			public function testValidateEmptyPasswordException()
35			{
36			$this->expectException(\InvalidArgumentException::class);
37
38			$password = new PasswordHasher();
39			$password->validate('', 'test');
40			}
41
42			/**
43			* In PHP 7.4 password hashing algorithm identifiers are now nullable strings rather than integers.
44			*/
45			public function testAlgorithmString()
46			{
47			$password = new PasswordHasher('test');
			0 ignored issues – show Unused Code introduced 2019-08-17 10:13 UTC by Report Bug Copy Issue Report The assignment to `$password` is dead and can be removed. Loading history...
48			$this->assertTrue(true);
49			}
50			}
51

yiisoft / security

Push — master ( 6b04c6...8a1192 )

PasswordHasherTest::testPasswordHash() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like