MacTest::testSignException() - Code Metrics - Inspection of "Add more tests, add strict types, fix typos" - yiisoft/security - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bdfe7b...8f2aab )

by Alexander

created 2019-08-17 10:56 UTC

MacTest::testSignException() A

↳ Parent: MacTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	0
dl	0
loc	7
rs	10
c	0
b	0
f	0

<?php

namespace Yiisoft\Security\Tests;

require_once __DIR__ . '/MockHelper.php';

use PHPUnit\Framework\TestCase;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Yiisoft\Security\DataIsTamperedException;
use Yiisoft\Security\Mac;
use Yiisoft\Security\MockHelper;

class MacTest extends TestCase
{
    protected function tearDown()
    {
        MockHelper::resetMocks();
    }

    public function testOriginalMessageIsExtracted(): void
    {
        $mac = new Mac();
        $data = 'known data';
        $key = 'secret';

        $signedData = $mac->sign($data, $key);
        $this->assertNotSame($data, $signedData);
        $this->assertSame($data, $mac->getMessage($signedData, $key));
    }

    public function testDataTamperingIsDetected(): void
    {
        $mac = new Mac();
        $data = 'known data';
        $key = 'secret';

        $signedData = $mac->sign($data, $key);
        $signedData[strlen($signedData) - 1] = 'A';

        $this->expectException(DataIsTamperedException::class);
        $mac->getMessage($signedData, $key);
    }

    public function testSignException()
    {
        $this->expectException(\RuntimeException::class);

        MockHelper::$mock_hash_hmac = false;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $mac = new Mac();
        $mac->sign('test', 'test');
    }

    public function testGetMessageException()
    {
        $this->expectException(\RuntimeException::class);

        MockHelper::$mock_hash_hmac = false;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $mac = new Mac();
        $mac->getMessage('test', 'test');
    }
}


1			<?php
2
3			namespace Yiisoft\Security\Tests;
4
5			require_once __DIR__ . '/MockHelper.php';
6
7			use PHPUnit\Framework\TestCase;
			0 ignored issues – show Bug introduced 2019-08-16 23:28 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Yiisoft\Security\Tests\TestCase`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
8			use Yiisoft\Security\DataIsTamperedException;
9			use Yiisoft\Security\Mac;
10			use Yiisoft\Security\MockHelper;
11
12			class MacTest extends TestCase
13			{
14			protected function tearDown()
15			{
16			MockHelper::resetMocks();
17			}
18
19			public function testOriginalMessageIsExtracted(): void
20			{
21			$mac = new Mac();
22			$data = 'known data';
23			$key = 'secret';
24
25			$signedData = $mac->sign($data, $key);
26			$this->assertNotSame($data, $signedData);
27			$this->assertSame($data, $mac->getMessage($signedData, $key));
28			}
29
30			public function testDataTamperingIsDetected(): void
31			{
32			$mac = new Mac();
33			$data = 'known data';
34			$key = 'secret';
35
36			$signedData = $mac->sign($data, $key);
37			$signedData[strlen($signedData) - 1] = 'A';
38
39			$this->expectException(DataIsTamperedException::class);
40			$mac->getMessage($signedData, $key);
41			}
42
43			public function testSignException()
44			{
45			$this->expectException(\RuntimeException::class);
46
47			MockHelper::$mock_hash_hmac = false;
			0 ignored issues – show Documentation Bug introduced 2019-08-16 23:28 UTC by Report Bug Copy Issue Report The property `$mock_hash_hmac` was declared of type `integer`, but `false` is of type `false`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
48			$mac = new Mac();
49			$mac->sign('test', 'test');
50			}
51
52			public function testGetMessageException()
53			{
54			$this->expectException(\RuntimeException::class);
55
56			MockHelper::$mock_hash_hmac = false;
			0 ignored issues – show Documentation Bug introduced 2019-08-17 10:36 UTC by Report Bug Copy Issue Report The property `$mock_hash_hmac` was declared of type `integer`, but `false` is of type `false`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
57			$mac = new Mac();
58			$mac->getMessage('test', 'test');
59			}
60			}
61

yiisoft / security

Push — master ( bdfe7b...8f2aab )

MacTest::testSignException() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like