Router::addRoute() - Code Metrics - Inspection of "Router refactoring" - yiisoft/router - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#60)

unknown

created 2020-08-17 00:58 UTC

Router::addRoute() A

↳ Parent: Router

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	5
rs	10

<?php

declare(strict_types=1);

namespace Yiisoft\Router;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Yiisoft\Router\Dispatcher\DispatcherInterface;
use Yiisoft\Router\Handler\HandlerAwareTrait;
use Yiisoft\Router\Route\RouteCollectionInterface;
use Yiisoft\Router\Route\RouteInterface;

use function array_merge;

final class Router implements RouterInterface, RouteCollectionInterface
{
    use HandlerAwareTrait;

    private RouteCollectionInterface $routeCollection;
    private MatcherInterface $matcher;
    private DispatcherInterface $dispatcher;

    public function __construct(RouteCollectionInterface $routeCollection, MatcherInterface $matcher, DispatcherInterface $dispatcher)
    {
        $this->routeCollection = clone $routeCollection;
        $this->matcher = $matcher;
        $this->dispatcher = $dispatcher;
    }

    public function getDispatcher(): DispatcherInterface
    {
        return $this->dispatcher;
    }

    public function withDispatcher(DispatcherInterface $dispatcher): self
    {
        $new = clone $this;
        $new->dispatcher = $dispatcher;
        return $new;
    }

    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $matchingResult = $this->match($request);
        if ($matchingResult->isSuccess()) {
            $route = $matchingResult->getRoute();
            $routeDispatcher = $route->getDispatcher();
            $handlers = array_merge($route->getHandlers(), $this->getHandlers());
            $handlers = array_merge(/** @scrutinizer ignore-type */ $route->getHandlers(), $this->getHandlers());

            if ($routeDispatcher !== null) {
                return $routeDispatcher->handlers($handlers)->handle($request);
                return $routeDispatcher->handlers($handlers)->/** @scrutinizer ignore-call */ handle($request);
            }

            $this->dispatcher = $this->dispatcher->handlers($handlers);
        }

        return $this->dispatcher->handle($request);
    }

    public function match(ServerRequestInterface $request): MatchingResult
    {
        return $this->matchForRoutes($this->routeCollection->getRoutes(), $request);
    }

    public function matchForRoutes(iterable $routes, ServerRequestInterface $request): MatchingResult
    {
        return $this->matcher->matchForRoutes($routes, $request);
    }

    public function addRoute(RouteInterface $route): self
    {
        $this->routeCollection = $this->routeCollection->addRoute($route);

        return $this;
    }

    public function addRoutes(array $routes): self
    {
        // TODO: Implement addRoutes() method.
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    public function addCollection(RouteCollectionInterface $collection): self
    {
        // TODO: Implement addCollection() method.
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    public function getRoutes(): iterable
    {
        return $this->routeCollection->getRoutes();
    }
}


yiisoft / router

Pull Request — master (#60)

Router::addRoute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like