Yiisoft\Router\Provider\AttributeRoutesProvider::getRoutes()

Complexity

Conditions	6
Paths	9

Size

Total Lines	38
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getRoutes(): array
    {
        $routes = [];
        $groupRoutes = [];
        $routePredicate = Attributes::predicateForAttributeInstanceOf(Route::class);
        $targetMethods = Attributes::filterTargetMethods($routePredicate);
        foreach ($targetMethods as $targetMethod) {
            /** @var Route $route */
            $route = $targetMethod->attribute;
            $targetMethodReflection = self::$reflectionsCache[$targetMethod->class] ??= new \ReflectionMethod(
                $targetMethod->class,
                $targetMethod->name
            );
            /** @var Group[] $groupAttributes */
            $groupAttributes = $targetMethodReflection->getAttributes(
                Group::class,
                \ReflectionAttribute::IS_INSTANCEOF
            );
            if (!empty($groupAttributes)) {
                $groupRoutes[$targetMethod->class][] = $route->action([$targetMethod->class, $targetMethod->name]);
            } else {
                $routes[] = $route->action([$targetMethod->class, $targetMethod->name]);
            }
        }
        $groupPredicate = static fn (string $attribute): bool => is_a($attribute, Route::class, true)
            || is_a($attribute, Group::class, true);
        $targetClasses = Attributes::filterTargetClasses($groupPredicate);
        foreach ($targetClasses as $targetClass) {
            if (isset($groupRoutes[$targetClass->name])) {
                /** @var Group $group */
                $group = $targetClass->attribute;
                $routes[] = $group->routes(...$groupRoutes[$targetClass->name]);
            } else {
                /** @var Route $group */
                $routes[] = $group->action($targetClass->name);

The variable $group seems to be defined later in this foreach loop on line 53. Are you sure it is defined here?

            }
        }
        return $routes;

The expression return $routes returns an array which contains values of type Yiisoft\Router\Route which are incompatible with the return type Yiisoft\Router\Group mandated by Yiisoft\Router\Provider\RoutesProviderInterface::getRoutes().

    }