anonymous//src/Route.php$2 ➔ wrapCallable()

Complexity

Conditions

1

Size

Total Lines

37

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	Route.php$1 ➔ __construct()	0	5	1
A	Route.php$2 ➔ __construct()	0	4	1
A	Route.php$2 ➔ process()	0	3	1
A	Route.php$1 ➔ process()	0	4	1

<?php

namespace Yiisoft\Router;

use InvalidArgumentException;
use Yiisoft\Http\Method;
use Yiisoft\Injector\Injector;
use Psr\Container\ContainerInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * Route defines a mapping from URL to callback / name and vice versa
 */
final class Route implements MiddlewareInterface
{
    private ?string $name = null;
    /** @var string[] */
    private array $methods;
    private string $pattern;
    private ?string $host = null;
    private ?ContainerInterface $container = null;
    /**
     * Contains a stack of middleware wrapped in handlers.
     * Each handler points to the handler of middleware that will be processed next.
     * @var RequestHandlerInterface|null stack of middleware
     */
    private ?RequestHandlerInterface $stack = null;

    /**
     * @var MiddlewareInterface[]|callable[]|string[]|array[]
     */
    private array $middlewares = [];
    private array $defaults = [];

    private function __construct(?ContainerInterface $container = null)
    {
        $this->container = $container;
    }

    public function withContainer(ContainerInterface $container)
    {
        $route = clone $this;
        $route->container = $container;
        return $route;
    }

    public function hasContainer()
    {
        return $this->container !== null;
    }

    /**
     * @param string $pattern
     * @param MiddlewareInterface|callable|string|array|null $middleware primary route handler {@see addMiddleware()}
     * @param ContainerInterface $container|null
     * @return static
     */
    public static function get(string $pattern, $middleware = null, ?ContainerInterface $container = null): self
    {
        return static::methods([Method::GET], $pattern, $middleware, $container);
    }

    /**
     * @param string $pattern
     * @param MiddlewareInterface|callable|string|array|null $middleware primary route handler {@see addMiddleware()}
     * @param ContainerInterface|null $container
     * @return static
     */
    public static function post(string $pattern, $middleware = null, ?ContainerInterface $container = null): self
    {
        return static::methods([Method::POST], $pattern, $middleware, $container);
    }

    /**
     * @param string $pattern
     * @param MiddlewareInterface|callable|string|array|null $middleware primary route handler {@see addMiddleware()}
     * @param ContainerInterface|null $container
     * @return static
     */
    public static function put(string $pattern, $middleware = null, ?ContainerInterface $container = null): self
    {
        return static::methods([Method::PUT], $pattern, $middleware, $container);
    }

    /**
     * @param string $pattern
     * @param MiddlewareInterface|callable|string|array|null $middleware primary route handler {@see addMiddleware()}
     * @param ContainerInterface|null $container
     * @return static
     */
    public static function delete(string $pattern, $middleware = null, ?ContainerInterface $container = null): self
    {
        return static::methods([Method::DELETE], $pattern, $middleware, $container);
    }

    /**
     * @param string $pattern
     * @param MiddlewareInterface|callable|string|array|null $middleware primary route handler {@see addMiddleware()}
     * @param ContainerInterface|null $container
     * @return static
     */
    public static function patch(string $pattern, $middleware = null, ?ContainerInterface $container = null): self
    {
        return static::methods([Method::PATCH], $pattern, $middleware, $container);
    }

    /**
     * @param string $pattern
     * @param MiddlewareInterface|callable|string|array|null $middleware primary route handler {@see addMiddleware()}
     * @param ContainerInterface|null $container
     * @return static
     */
    public static function head(string $pattern, $middleware = null, ?ContainerInterface $container = null): self
    {
        return static::methods([Method::HEAD], $pattern, $middleware, $container);
    }

    /**
     * @param string $pattern
     * @param MiddlewareInterface|callable|string|array|null $middleware primary route handler {@see addMiddleware()}
     * @param ContainerInterface|null $container
     * @return static
     */
    public static function options(string $pattern, $middleware = null, ?ContainerInterface $container = null): self
    {
        return static::methods([Method::OPTIONS], $pattern, $middleware, $container);
    }

    /**
     * @param array $methods
     * @param string $pattern
     * @param MiddlewareInterface|callable|string|array|null $middleware primary route handler {@see addMiddleware()}
     * @param ContainerInterface|null $container
     * @return static
     */
    public static function methods(array $methods, string $pattern, $middleware = null, ?ContainerInterface $container = null): self
    {
        $route = new static($container);
        $route->methods = $methods;
        $route->pattern = $pattern;
        if ($middleware !== null) {
            $route->validateMiddleware($middleware);
            $route->middlewares[] = $middleware;
        }
        return $route;
    }

    /**
     * @param string $pattern
     * @param MiddlewareInterface|callable|string|array|null $middleware primary route handler {@see addMiddleware()}
     * @param ContainerInterface|null $container
     * @return static
     */
    public static function anyMethod(string $pattern, $middleware = null, ?ContainerInterface $container = null): self
    {
        return static::methods(Method::ANY, $pattern, $middleware, $container);
    }

    public function name(string $name): self
    {
        $route = clone $this;
        $route->name = $name;
        return $route;
    }

    public function pattern(string $pattern): self
    {
        $new = clone $this;
        $new->pattern = $pattern;
        return $new;
    }

    public function host(string $host): self
    {
        $route = clone $this;
        $route->host = rtrim($host, '/');
        return $route;
    }

    /**
     * Parameter default values indexed by parameter names
     *
     * @param array $defaults
     * @return self
     */
    public function defaults(array $defaults): self
    {
        $route = clone $this;
        $route->defaults = $defaults;
        return $route;
    }

    /**
     * @param MiddlewareInterface|callable|string|array $middleware
     */
    private function validateMiddleware($middleware): void
    {
        if (
            is_string($middleware) && is_subclass_of($middleware, MiddlewareInterface::class)
        ) {
            return;
        }

        if (is_callable($middleware)) {
            return;
        }

        throw new InvalidArgumentException('Parameter should be either PSR middleware class name, handler action or a callable.');
    }

    /**
     * @param MiddlewareInterface|callable|string|array $middleware
     * @return MiddlewareInterface|string|array
     */
    private function prepareMiddleware($middleware)
    {
        if (is_string($middleware)) {
            if ($this->container === null) {
                throw new InvalidArgumentException('Route container must not be null for lazy loaded middleware.');
            }
            return $this->container->get($middleware);
        }

        if (is_array($middleware) && !is_object($middleware[0])) {
            if ($this->container === null) {
                throw new InvalidArgumentException('Route container must not be null for handler action.');
            }
            return $this->wrapCallable($middleware);
        }

        if (is_callable($middleware)) {
            if ($this->container === null) {
                throw new InvalidArgumentException('Route container must not be null for callable.');
            }
            return $this->wrapCallable($middleware);
        }

        return $middleware;

The expression return $middleware also could return the type callable which is incompatible with the documented return type Psr\Http\Server\MiddlewareInterface|array|string.

    }

    /**
     * Prepends a handler that should be invoked for a matching route.
     * Last added handler will be invoked first.
     *
     * Parameter should be either PSR middleware instance, PSR middleware class name, handler action or a callable.
     *
     * It can be a PSR middleware instance, PSR middleware class name, handler action
     * (an array of [handlerClass, handlerMethod]) or a callable.
     *
     * For handler action and callable typed parameters are automatically injected using dependency
     * injection container passed to the route. Current request and handler could be obtained by
     * type-hinting for ServerRequestInterface and RequestHandlerInterface.
     *
     * @param MiddlewareInterface|callable|string|array $middleware
     * @return Route
     */
    public function addMiddleware($middleware): self
    {
        $this->validateMiddleware($middleware);

        $route = clone $this;
        $route->middlewares[] = $middleware;
        return $route;
    }

    public function __toString(): string
    {
        $result = '';

        if ($this->name !== null) {
            $result .= '[' . $this->name . '] ';
        }

        if ($this->methods !== []) {
            $result .= implode(',', $this->methods) . ' ';
        }
        if ($this->host !== null && strrpos($this->pattern, $this->host) === false) {
            $result .= $this->host;
        }
        $result .= $this->pattern;

        return $result;
    }

    public function getName(): string
    {
        return $this->name ?? (implode(', ', $this->methods) . ' ' . $this->pattern);
    }

    public function getMethods(): array
    {
        return $this->methods;
    }

    public function getPattern(): string
    {
        return $this->pattern;
    }

    public function getHost(): ?string
    {
        return $this->host;
    }

    public function getDefaults(): array
    {
        return $this->defaults;
    }

    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        if ($this->stack === null) {
            foreach ($this->middlewares as $middleware) {
                $handler = $this->wrap($this->prepareMiddleware($middleware), $handler);
            }
            $this->stack = $handler;
        }

        return $this->stack->handle($request);

The method handle() does not exist on null.

    }

    /**
     * Wraps handler by middlewares
     */
    private function wrap(MiddlewareInterface $middleware, RequestHandlerInterface $handler): RequestHandlerInterface
    {
        return new class($middleware, $handler) implements RequestHandlerInterface {
            private MiddlewareInterface $middleware;
            private RequestHandlerInterface $handler;

            public function __construct(MiddlewareInterface $middleware, RequestHandlerInterface $handler)
            {
                $this->middleware = $middleware;
                $this->handler = $handler;
            }

            public function handle(ServerRequestInterface $request): ResponseInterface
            {
                return $this->middleware->process($request, $this->handler);
            }
        };
    }

    private function wrapCallable($callback): MiddlewareInterface
    {
        if (is_array($callback) && !is_object($callback[0])) {
            [$controller, $action] = $callback;
            return new class($controller, $action, $this->container) implements MiddlewareInterface {

It seems like $this->container can also be of type null; however, parameter $container of anonymous//src/Route.php$1::__construct() does only seem to accept Psr\Container\ContainerInterface, maybe add an additional type check?

                private string $class;
                private string $method;
                private ContainerInterface $container;

                public function __construct(string $class, string $method, ContainerInterface $container)
                {
                    $this->class = $class;
                    $this->method = $method;
                    $this->container = $container;
                }

                public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
                {
                    $controller = $this->container->get($this->class);
                    return (new Injector($this->container))->invoke([$controller, $this->method], [$request, $handler]);
                }
            };
        }

        return new class($callback, $this->container) implements MiddlewareInterface {

It seems like $this->container can also be of type null; however, parameter $container of anonymous//src/Route.php$2::__construct() does only seem to accept Psr\Container\ContainerInterface, maybe add an additional type check?

            private ContainerInterface $container;
            private $callback;

            public function __construct(callable $callback, ContainerInterface $container)
            {
                $this->callback = $callback;
                $this->container = $container;
            }

            public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
            {
                return (new Injector($this->container))->invoke($this->callback, [$request, $handler]);
            }
        };
    }
}