Delete::__construct() - Code Metrics - Inspection of "Add attributes support & improve `MatchingResult`" - yiisoft/router - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#196)

by Sergei

created 2023-10-15 14:04 UTC

Delete::__construct() A

↳ Parent: Delete

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	9
nc	1
nop	7
dl	0
loc	18
ccs	10
cts	10
cp	1
crap	1
rs	9.9666
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Yiisoft\Router\Attribute;

use Attribute;
use Stringable;
use Yiisoft\Http\Method;
use Yiisoft\Router\Route;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

#[Attribute(Attribute::TARGET_METHOD | Attribute::TARGET_CLASS | Attribute::IS_REPEATABLE)]
final class Delete implements RouteAttributeInterface
{
    private Route $route;

    /**
     * @param array<string,scalar|Stringable|null> $defaults Parameter default values indexed by parameter names.
     * @param bool $override Marks route as override. When added it will replace existing route with the same name.
     * @param array $disabledMiddlewares Excludes middleware from being invoked when action is handled.
     * It is useful to avoid invoking one of the parent group middleware for
     * a certain route.
     */
    public function __construct(
        string $pattern,
        ?string $name = null,
        array $middlewares = [],
        array $defaults = [],
        array $hosts = [],
        bool $override = false,
        array $disabledMiddlewares = []
    ) {
        $this->route = new Route(
            methods: [Method::DELETE],
            pattern: $pattern,
            name: $name,
            middlewares: $middlewares,
            defaults: $defaults,
            hosts: $hosts,
            override: $override,
            disabledMiddlewares: $disabledMiddlewares
        );
    }

    public function getRoute(): Route
    {
        return $this->route;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Router\Attribute;
6
7		use Attribute;
8		use Stringable;
9		use Yiisoft\Http\Method;
10		use Yiisoft\Router\Route;
		0 ignored issues – show Bug introduced 2023-10-15 14:06 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Yiisoft\Router\Attribute\Route`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
11
12		#[Attribute(Attribute::TARGET_METHOD \| Attribute::TARGET_CLASS \| Attribute::IS_REPEATABLE)]
13		final class Delete implements RouteAttributeInterface
14		{
15		private Route $route;
16
17		/**
18		* @param array<string,scalar\|Stringable\|null> $defaults Parameter default values indexed by parameter names.
19		* @param bool $override Marks route as override. When added it will replace existing route with the same name.
20		* @param array $disabledMiddlewares Excludes middleware from being invoked when action is handled.
21		* It is useful to avoid invoking one of the parent group middleware for
22		* a certain route.
23		*/
24	2	public function __construct(
25		string $pattern,
26		?string $name = null,
27		array $middlewares = [],
28		array $defaults = [],
29		array $hosts = [],
30		bool $override = false,
31		array $disabledMiddlewares = []
32		) {
33	2	$this->route = new Route(
34	2	methods: [Method::DELETE],
35	2	pattern: $pattern,
36	2	name: $name,
37	2	middlewares: $middlewares,
38	2	defaults: $defaults,
39	2	hosts: $hosts,
40	2	override: $override,
41	2	disabledMiddlewares: $disabledMiddlewares
42	2	);
43		}
44
45	2	public function getRoute(): Route
46		{
47	2	return $this->route;
48		}
49		}
50

yiisoft / router

Pull Request — master (#196)

Delete::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like