RequestModel::getValue() - Code Metrics - Inspection of "Not required fields" - yiisoft/request-model - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#14)

by Sergei

created 2021-01-10 08:48 UTC

RequestModel::getValue() A

↳ Parent: RequestModel

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	5
nc	3
nop	2
dl	0
loc	10
ccs	6
cts	6
cp	1
crap	3
rs	10
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Yiisoft\RequestModel;

use Yiisoft\Arrays\ArrayHelper;

abstract class RequestModel implements RequestModelInterface
{
    private array $requestData = [];

    public function setRequestData(array $requestData): void
    {
        $this->requestData = $requestData;
    }

    public function getValue(string $field, $default = null)
    {
        if ($this->isOptionalField($field)) {
            $value = ArrayHelper::getValueByPath($this->requestData, $field);
            if (empty($value)) {
                return $default;
            }
        }

        return ArrayHelper::getValueByPath($this->requestData, $field, $default);
    }

    public function hasValue(string $field): bool
    {
        return $this->getValue($field) !== null;
    }

    public function getRequestData(): array
    {
        return $this->requestData;
    }

    public function getOptionalFields(): array
    {
        return [];
    }

    private function isOptionalField(string $field): bool
    {
        return in_array($field, $this->getOptionalFields());
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\RequestModel;
6
7		use Yiisoft\Arrays\ArrayHelper;
8
9		abstract class RequestModel implements RequestModelInterface
10		{
11		private array $requestData = [];
12
13	20	public function setRequestData(array $requestData): void
14		{
15	20	$this->requestData = $requestData;
16	20	}
17
18	17	public function getValue(string $field, $default = null)
19		{
20	17	if ($this->isOptionalField($field)) {
21	9	$value = ArrayHelper::getValueByPath($this->requestData, $field);
22	9	if (empty($value)) {
23	5	return $default;
24		}
25		}
26
27	12	return ArrayHelper::getValueByPath($this->requestData, $field, $default);
28		}
29
30	1	public function hasValue(string $field): bool
31		{
32	1	return $this->getValue($field) !== null;
33		}
34
35	2	public function getRequestData(): array
36		{
37	2	return $this->requestData;
38		}
39
40	11	public function getOptionalFields(): array
41		{
42	11	return [];
43		}
44
45	17	private function isOptionalField(string $field): bool
46		{
47	17	return in_array($field, $this->getOptionalFields());
48		}
49		}
50

yiisoft / request-model

Pull Request — master (#14)

RequestModel::getValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like