SimpleCacheStorage::get() - Code Metrics - Inspection of "Concurrent security" - yiisoft/rate-limiter - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#43)

by Sergei

created 2023-07-03 11:43 UTC

SimpleCacheStorage::get() B

↳ Parent: SimpleCacheStorage

Complexity

Conditions	7
Paths	5

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	5
c	1
b	0
f	0
dl	0
loc	9
ccs	0
cts	0
cp	0
rs	8.8333
cc	7
nc	5
nop	1
crap	56

<?php

declare(strict_types=1);

namespace Yiisoft\Yii\RateLimiter\Storage;

use InvalidArgumentException;
use Psr\SimpleCache\CacheInterface;

final class SimpleCacheStorage implements StorageInterface
{
    public function __construct(private CacheInterface $cache)
    {
    }

    public function saveIfNotExists(string $key, mixed $value, int $ttl): bool
    {
        return $this->cache->set($key, $value, $ttl);
    }

    public function saveCompareAndSwap(string $key, mixed $oldValue, mixed $newValue, int $ttl): bool
    {
        return $this->cache->set($key, $newValue, $ttl);
    }

    public function get(string $key): ?float
    {
        $value = $this->cache->get($key);
        if (!is_int($value) && !is_float($value) && $value !== false && $value !== null) {
            throw new InvalidArgumentException('The value is not supported by SimpleCacheStorage, it must be int, float or null.');
        }

        $value = ($value === false || $value === null) ? null : (float)$value;
        return $value;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Yii\RateLimiter\Storage;
6
7		use InvalidArgumentException;
8		use Psr\SimpleCache\CacheInterface;
9
10		final class SimpleCacheStorage implements StorageInterface
11	10	{
12		public function __construct(private CacheInterface $cache)
13	10	{
14		}
15	6
16		public function saveIfNotExists(string $key, mixed $value, int $ttl): bool
17	6	{
18		return $this->cache->set($key, $value, $ttl);
19		}
20	7
21		public function saveCompareAndSwap(string $key, mixed $oldValue, mixed $newValue, int $ttl): bool
22	7	{
23		return $this->cache->set($key, $newValue, $ttl);
24		}
25
26		public function get(string $key): ?float
27		{
28		$value = $this->cache->get($key);
29		if (!is_int($value) && !is_float($value) && $value !== false && $value !== null) {
30		throw new InvalidArgumentException('The value is not supported by SimpleCacheStorage, it must be int, float or null.');
31		}
32
33		$value = ($value === false \|\| $value === null) ? null : (float)$value;
34		return $value;
35		}
36		}
37

yiisoft / rate-limiter

Pull Request — master (#43)

SimpleCacheStorage::get() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like