yiisoft / queue

src/Middleware/CallableFactory.php

<?php

declare(strict_types=1);

namespace Yiisoft\Queue\Middleware;

use Psr\Container\ContainerExceptionInterface;
use Psr\Container\ContainerInterface;
use Psr\Container\NotFoundExceptionInterface;
use ReflectionException;
use ReflectionMethod;

use function is_array;
use function is_callable;
use function is_string;

/**
 * @internal Create real callable listener from configuration.
 */
final class CallableFactory
{
    public function __construct(private ContainerInterface $container)
    {
    }

    /**
     * Create real callable listener from definition.
     *
     * @param mixed $definition Definition to create listener from.
     *
     * @throws InvalidCallableConfigurationException Failed to create listener.
     * @throws ContainerExceptionInterface Error while retrieving the entry from container.
     */
    public function create(mixed $definition): callable
    {
        $callable = null;

        if (is_string($definition) && $this->container->has($definition)) {
            // Object with an __invoke() method
            $callable = $this->container->get($definition);
        }

        if (is_array($definition)
            && array_keys($definition) === [0, 1]
            && is_string($definition[0])
            && is_string($definition[1])
        ) {
            [$className, $methodName] = $definition;
            $callable = $this->fromDefinition($className, $methodName);
        }

        if ($callable === null) {
            $callable = $definition;
        }

        if (is_callable($callable)) {
            return $callable;

The expression return $callable could return the type null which is incompatible with the type-hinted return callable. Consider adding an additional type-check to rule them out.

        }

        throw new InvalidCallableConfigurationException();
    }

    /**
     * @throws ContainerExceptionInterface Error while retrieving the entry from container.
     * @throws NotFoundExceptionInterface
     */
    private function fromDefinition(string $className, string $methodName): ?callable
    {
        $result = null;

        if (class_exists($className)) {
            try {
                $reflection = new ReflectionMethod($className, $methodName);
                if ($reflection->isStatic()) {
                    $result = [$className, $methodName];
                }
            } catch (ReflectionException) {

Consider adding a comment why this CATCH block is empty.

            }
        }

        if ($result === null && $this->container->has($className)) {
            $result = [
                $this->container->get($className),
                $methodName,
            ];
        }

        return is_callable($result) ? $result : null;
    }
}