ObjectProxy::call() - Code Metrics - Inspection of "Move code to trait" - yiisoft/proxy - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#4)

by Dmitriy

created 2020-03-08 12:54 UTC

ObjectProxy::call() A

↳ Parent: ObjectProxy

Complexity

Conditions	2
Paths	4

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	10
c	1
b	0
f	0
nc	4
nop	2
dl	0
loc	14
ccs	0
cts	13
cp	0
crap	6
rs	9.9332

<?php

namespace Yiisoft\Proxy;

abstract class ObjectProxy
{
    use ProxyTrait;

    private object $instance;

    public function __construct(object $instance)
    {
        $this->instance = $instance;
    }

    protected function call(string $methodName, array $arguments)
    {
        $this->resetCurrentError();
        $result = null;

        $timeStart = microtime(true);
        try {
            $result = $this->callInternal($methodName, $arguments);
        } catch (\Exception $e) {
            $this->repeatError($e);
        } finally {
            $result = $this->executeMethodProxy($methodName, $arguments, $result, $timeStart);
        }

        return $this->processResult($result);
    }

    abstract protected function executeMethodProxy(string $methodName, array $arguments, $result, float $timeStart);

    protected function getNewStaticInstance(object $instance): self
    {
        return new static($instance);
    }

    protected function getInstance(): object
    {
        return $this->instance;
    }

    private function callInternal(string $methodName, array $arguments)
    {
        return $this->instance->$methodName(...$arguments);
    }

    private function processResult($result)
    {
        if (is_object($result) && get_class($result) === get_class($this->instance)) {
            $result = $this->getNewStaticInstance($result);
        }

        return $result;
    }
}


1			<?php
2
3			namespace Yiisoft\Proxy;
4
5			abstract class ObjectProxy
6			{
7			use ProxyTrait;
8
9			private object $instance;
10
11			public function __construct(object $instance)
12			{
13			$this->instance = $instance;
14			}
15
16			protected function call(string $methodName, array $arguments)
17			{
18			$this->resetCurrentError();
19			$result = null;
			0 ignored issues – show Unused Code introduced 2020-03-03 20:43 UTC by Report Bug Copy Issue Report The assignment to `$result` is dead and can be removed. Loading history...
20			$timeStart = microtime(true);
21			try {
22			$result = $this->callInternal($methodName, $arguments);
23			} catch (\Exception $e) {
24			$this->repeatError($e);
25			} finally {
26			$result = $this->executeMethodProxy($methodName, $arguments, $result, $timeStart);
27			}
28
29			return $this->processResult($result);
30			}
31
32			abstract protected function executeMethodProxy(string $methodName, array $arguments, $result, float $timeStart);
33
34			protected function getNewStaticInstance(object $instance): self
35			{
36			return new static($instance);
37			}
38
39			protected function getInstance(): object
40			{
41			return $this->instance;
42			}
43
44			private function callInternal(string $methodName, array $arguments)
45			{
46			return $this->instance->$methodName(...$arguments);
47			}
48
49			private function processResult($result)
50			{
51			if (is_object($result) && get_class($result) === get_class($this->instance)) {
52			$result = $this->getNewStaticInstance($result);
53			}
54
55			return $result;
56			}
57			}
58

yiisoft / proxy

Pull Request — master (#4)

ObjectProxy::call() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like