Yiisoft\Proxy\ObjectProxy

Complexity

Total Complexity

9

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

90.91%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	callInternal()	0	3	1
A	getInstance()	0	3	1
A	__construct()	0	3	1
A	processResult()	0	7	3
A	getNewStaticInstance()	0	3	1
A	call()	0	14	2

<?php

declare(strict_types=1);

namespace Yiisoft\Proxy;

use Exception;

abstract class ObjectProxy
{
    use ProxyTrait;

    private object $instance;

    public function __construct(object $instance)
    {
        $this->instance = $instance;
    }

    protected function call(string $methodName, array $arguments)
    {
        $this->resetCurrentError();
        $result = null;

The assignment to $result is dead and can be removed.

        $timeStart = microtime(true);
        try {
            $result = $this->callInternal($methodName, $arguments);
        } catch (Exception $e) {
            $this->repeatError($e);
        } finally {
            $result = $this->executeMethodProxy($methodName, $arguments, $result, $timeStart);

It seems like $timeStart can also be of type string; however, parameter $timeStart of Yiisoft\Proxy\ObjectProxy::executeMethodProxy() does only seem to accept double, maybe add an additional type check?

        }

        return $this->processResult($result);
    }

    abstract protected function executeMethodProxy(string $methodName, array $arguments, $result, float $timeStart);

    protected function getNewStaticInstance(object $instance): self
    {
        return new static($instance);
    }

    protected function getInstance(): object
    {
        return $this->instance;
    }

    private function callInternal(string $methodName, array $arguments)
    {
        return $this->instance->$methodName(...$arguments);
    }

    private function processResult($result)
    {
        if (is_object($result) && get_class($result) === get_class($this->instance)) {
            $result = $this->getNewStaticInstance($result);
        }

        return $result;
    }
}