DnsHelper::checkMx() - Code Metrics - Inspection of "DnsHelper for email check #10" - yiisoft/network-utilities - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#11)

unknown

created 2019-11-05 11:10 UTC

DnsHelper::checkMx() A

↳ Parent: DnsHelper

Complexity

Conditions	4
Paths	6

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	4.25

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	8
c	1
b	0
f	0
nc	6
nop	1
dl	0
loc	12
rs	10
ccs	6
cts	8
cp	0.75
crap	4.25

<?php

namespace Yiisoft\NetworkUtilities;

class DnsHelper
{
    /**
     * @param string $hostname hostname without dot at end
     */
    public static function checkMx(string $hostname): bool
    {
        $hostname .= '.';
        try {
            if (!@dns_check_record($hostname, 'MX')) {
                return false;
            }
            $result = @dns_get_record($hostname, DNS_MX);
            return $result !== false && count($result) > 0;
        } catch (\Throwable $t) {

        }
        return false;
    }

    public static function checkA(string $hostname): bool
    {
        try {
            if (!@dns_check_record($hostname, 'A')) {
                return false;
            }
            $result = @dns_get_record($hostname, DNS_A);
            return $result !== false && count($result) > 0;
        } catch (\Throwable $t) {

        }
        return false;
    }

    public static function checkForEmail(string $hostnameOrEmail): bool
    {
        if (strpos($hostnameOrEmail, '@') !== false) {
            [$void, $hostnameOrEmail] = explode('@', $hostnameOrEmail, 2);
        }
        return self::checkMx($hostnameOrEmail) || self::checkA($hostnameOrEmail);
    }
}

1		<?php
2
3		namespace Yiisoft\NetworkUtilities;
4
5		class DnsHelper
6		{
7		/**
8		* @param string $hostname hostname without dot at end
9		*/
10	2	public static function checkMx(string $hostname): bool
11		{
12	2	$hostname .= '.';
13		try {
14	2	if (!@dns_check_record($hostname, 'MX')) {
15	2	return false;
16		}
17	2	$result = @dns_get_record($hostname, DNS_MX);
18	2	return $result !== false && count($result) > 0;
19		} catch (\Throwable $t) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-11-05 11:12 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
20		}
21		return false;
22		}
23
24	2	public static function checkA(string $hostname): bool
25		{
26		try {
27	2	if (!@dns_check_record($hostname, 'A')) {
28	2	return false;
29		}
30	1	$result = @dns_get_record($hostname, DNS_A);
31	1	return $result !== false && count($result) > 0;
32		} catch (\Throwable $t) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-11-05 11:12 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
33		}
34		return false;
35		}
36
37	1	public static function checkForEmail(string $hostnameOrEmail): bool
38		{
39	1	if (strpos($hostnameOrEmail, '@') !== false) {
40	1	[$void, $hostnameOrEmail] = explode('@', $hostnameOrEmail, 2);
41		}
42	1	return self::checkMx($hostnameOrEmail) \|\| self::checkA($hostnameOrEmail);
43		}
44		}

yiisoft / network-utilities

Pull Request — master (#11)

DnsHelper::checkMx() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like