yiisoft / mutex-file

src/FileMutex.php

<?php

declare(strict_types=1);

namespace Yiisoft\Mutex\File;

use Yiisoft\Files\FileHelper;
use Yiisoft\Mutex\Mutex;

use function chmod;
use function clearstatcache;
use function fclose;
use function fileinode;
use function flock;
use function fopen;
use function fstat;
use function md5;
use function unlink;

/**
 * FileMutex implements mutex "lock" mechanism via local file system files.
 *
 * This component relies on PHP {@see flock()} function.
 *
 * > Note: this component can maintain the locks only for the single web server,
 * > it probably will not suffice in case you are using cloud server solution.
 *
 * > Warning: due to {@see flock()} function nature this component is unreliable when
 * > using a multithreaded server API like ISAPI.
 */
final class FileMutex extends Mutex
{
    private string $lockFilePath;
    private ?int $fileMode;

    /**
     * @var closed-resource|resource|null Stores opened lock file resource.

The doc comment closed-resource|resource|null at position 0 could not be parsed: Unknown type name 'closed-resource' at position 0 in closed-resource|resource|null.

     */
    private $lockResource = null;

    /**
     * @param string $name Mutex name.
     * @param string $mutexPath The directory to store mutex files.
     * @param int $directoryMode The permission to be set for newly created directories.
     * This value will be used by PHP {@see chmod()} function. No umask will be applied. Defaults to 0775,
     * meaning the directory is read-writable by owner and group, but read-only for other users.
     * @param int|null $fileMode The permission to be set for newly created mutex files.
     * This value will be used by PHP {@see chmod()} function. No umask will be applied.
     */
    public function __construct(string $name, string $mutexPath, int $directoryMode = 0775, int $fileMode = null)
    {
        FileHelper::ensureDirectory($mutexPath, $directoryMode);
        $this->lockFilePath = $mutexPath . DIRECTORY_SEPARATOR . md5($name) . '.lock';
        $this->fileMode = $fileMode;
        parent::__construct(self::class, $name);
    }

    protected function acquireLock(int $timeout = 0): bool
    {
        $resource = fopen($this->lockFilePath, 'wb+');

        if ($resource === false) {
            return false;
        }

        if ($this->fileMode !== null) {
            @chmod($this->lockFilePath, $this->fileMode);

It seems like you do not handle an error condition for chmod(). This can introduce security issues, and is generally not recommended.

        }

        if (!flock($resource, LOCK_EX | LOCK_NB)) {
            fclose($resource);
            return false;
        }

        // Under unix, we delete the lock file before releasing the related handle. Thus, it's possible that we've
        // acquired a lock on a non-existing file here (race condition). We must compare the inode of the lock file
        // handle with the inode of the actual lock file.
        // If they do not match we simply continue the loop since we can assume the inodes will be equal on the
        // next try.
        // Example of race condition without inode-comparison:
        // Script A: locks file
        // Script B: opens file
        // Script A: unlinks and unlocks file
        // Script B: locks handle of *unlinked* file
        // Script C: opens and locks *new* file
        // In this case we would have acquired two locks for the same file path.
        if (DIRECTORY_SEPARATOR !== '\\' && fstat($resource)['ino'] !== @fileinode($this->lockFilePath)) {
            clearstatcache(true, $this->lockFilePath);
            flock($resource, LOCK_UN);
            fclose($resource);

            return false;
        }

        $this->lockResource = $resource;
        return true;
    }

    protected function releaseLock(): bool
    {
        if (!is_resource($this->lockResource)) {
            return false;
        }

        if (DIRECTORY_SEPARATOR === '\\') {
            // Under windows, it's not possible to delete a file opened via fopen (either by own or other process).
            // That's why we must first unlock and close the handle and then *try* to delete the lock file.
            flock($this->lockResource, LOCK_UN);
            fclose($this->lockResource);
            @unlink($this->lockFilePath);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        } else {
            // Under unix, it's possible to delete a file opened via fopen (either by own or other process).
            // That's why we must unlink (the currently locked) lock file first and then unlock and close the handle.
            @unlink($this->lockFilePath);
            flock($this->lockResource, LOCK_UN);
            fclose($this->lockResource);
        }

        $this->lockResource = null;
        return true;
    }
}