MiddlewareFactory.php$1 ➔ __construct() - Code Metrics - Inspection of "Remove wrapper factory, move parameters resolver f..." - yiisoft/middleware-dispatcher - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#68)

by Sergei
created 2022-12-19 07:10 UTC
MiddlewareFactory.php$1 ➔ __construct() A

↳ Parent: anonymous//src/MiddlewareFactory.php$1
Complexity

Conditions
Size

Total Lines
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	2
Importance

Changes	2
Bugs	0	Features	0
Metric	Value
c	2
b	0
f	0
dl	0
loc	8
ccs	0
cts	0
cp	0
rs	10
cc	1
crap	2
<?php

declare(strict_types=1);

namespace Yiisoft\Middleware\Dispatcher;

use Closure;
use Psr\Container\ContainerInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use ReflectionClass;
use ReflectionFunction;
use Yiisoft\Definitions\ArrayDefinition;
use Yiisoft\Definitions\Exception\InvalidConfigException;
use Yiisoft\Definitions\Helpers\DefinitionValidator;
use Yiisoft\Injector\Injector;

use function in_array;
use function is_array;
use function is_string;

/**
 * Creates a PSR-15 middleware based on the definition provided.
 *
 * @psalm-import-type ArrayDefinitionConfig from ArrayDefinition
 */
final class MiddlewareFactory
{
    /**
     * @param ContainerInterface $container Container to use for resolving definitions.
     */
    public function __construct(
        private ContainerInterface $container,
        private ?ParametersResolverInterface $parametersResolver = null
    ) {
    }

    /**
     * @param array|callable|string $middlewareDefinition Middleware definition in one of the following formats:
     *
     * - A name of PSR-15 middleware class. The middleware instance will be obtained from container and executed.
     * - A callable with
     *   `function(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface`
     *   signature.
     * - A controller handler action in format `[TestController::class, 'index']`. `TestController` instance will
     *   be created and `index()` method will be executed.
     * - A function returning a middleware. The middleware returned will be executed.
     *
     * For handler action and callable
     * typed parameters are automatically injected using dependency injection container.
     * Current request and handler could be obtained by type-hinting for {@see ServerRequestInterface}
     * and {@see RequestHandlerInterface}.
     *
     * @throws InvalidMiddlewareDefinitionException
     */
    public function create(array|callable|string $middlewareDefinition): MiddlewareInterface
    {
        if ($this->isMiddlewareClassDefinition($middlewareDefinition)) {
            /** @var MiddlewareInterface */
            return $this->container->get($middlewareDefinition);
            return $this->container->get(/** @scrutinizer ignore-type */ $middlewareDefinition);
        }

        if ($this->isCallableDefinition($middlewareDefinition)) {
            return $this->wrapCallable($middlewareDefinition);
        }

        if ($this->isArrayDefinition($middlewareDefinition)) {
            /** @var MiddlewareInterface */
            return ArrayDefinition::fromConfig($middlewareDefinition)->resolve($this->container);
        }

        throw new InvalidMiddlewareDefinitionException($middlewareDefinition);
    }

    /**
     * @psalm-assert-if-true class-string<MiddlewareInterface> $definition
     */
    private function isMiddlewareClassDefinition(array|callable|string $definition): bool
    {
        return is_string($definition)
            && is_subclass_of($definition, MiddlewareInterface::class);
    }

    /**
     * @psalm-assert-if-true array{0:class-string, 1:non-empty-string}|Closure $definition
     */
    private function isCallableDefinition(array|callable|string $definition): bool
    {
        if ($definition instanceof Closure) {

            return true;
        }

        return is_array($definition)
            && array_keys($definition) === [0, 1]
            && is_string($definition[0])
            && is_string($definition[1])
            && in_array(
                $definition[1],
                class_exists($definition[0]) ? get_class_methods($definition[0]) : [],
                true
            );
    }

    /**
     * @psalm-assert-if-true ArrayDefinitionConfig $definition
     */
    private function isArrayDefinition(array|callable|string $definition): bool
    {
        if (!is_array($definition)) {

            return false;
        }

        try {
            DefinitionValidator::validateArrayDefinition($definition);
        } catch (InvalidConfigException) {
            return false;
        }

        return is_subclass_of((string)($definition['class'] ?? ''), MiddlewareInterface::class);
    }

    /**
     * @param array{0:class-string, 1:non-empty-string}|Closure $callable

     */
    private function wrapCallable(array|Closure $callable): MiddlewareInterface
    {
        if (is_array($callable)) {

            return $this->createActionWrapper($callable[0], $callable[1]);
        }

        return $this->createCallableWrapper($callable);
    }

    private function createCallableWrapper(callable $callback): MiddlewareInterface
    {
        return new class ($callback, $this->container, $this->parametersResolver) implements MiddlewareInterface {
            private $callback;

            public function __construct(
                callable $callback,
                private ContainerInterface $container,
                private ?ParametersResolverInterface $parametersResolver
            ) {
                $this->callback = $callback;
            }

            public function process(
                ServerRequestInterface $request,
                RequestHandlerInterface $handler
            ): ResponseInterface {
                $parameters = [$request, $handler];
                if ($this->parametersResolver !== null) {
                    $parameters = array_merge(
                        $parameters,
                        $this->parametersResolver->resolve($this->getCallableParameters(), $request)
                    );
                }
                /** @var MiddlewareInterface|mixed|ResponseInterface $response */
                $response = (new Injector($this->container))->invoke($this->callback, $parameters);
                if ($response instanceof ResponseInterface) {
                    return $response;
                }
                if ($response instanceof MiddlewareInterface) {
                    return $response->process($request, $handler);
                }
                throw new InvalidMiddlewareDefinitionException($this->callback);
            }

            /**
             * @return \ReflectionParameter[]
             */
            private function getCallableParameters(): array
            {
                $callback = Closure::fromCallable($this->callback);

                return (new ReflectionFunction($callback))->getParameters();
            }
        };
    }

    /**
     * @param class-string $class

     * @param non-empty-string $method
     */
    private function createActionWrapper(string $class, string $method): MiddlewareInterface
    {
        return new class ($this->container, $this->parametersResolver, $class, $method) implements MiddlewareInterface {
            public function __construct(
                private ContainerInterface $container,
                private ?ParametersResolverInterface $parametersResolver,
                /** @var class-string */
                private string $class,
                /** @var non-empty-string */
                private string $method
            ) {
            }

            public function process(
                ServerRequestInterface $request,
                RequestHandlerInterface $handler
            ): ResponseInterface {
                /** @var mixed $controller */
                $controller = $this->container->get($this->class);
                $parameters = [$request, $handler];
                if ($this->parametersResolver !== null) {
                    $parameters = array_merge(
                        $parameters,
                        $this->parametersResolver->resolve($this->getActionParameters(), $request)
                    );
                }

                /** @var mixed|ResponseInterface $response */
                $response = (new Injector($this->container))->invoke([$controller, $this->method], $parameters);
                if ($response instanceof ResponseInterface) {
                    return $response;
                }

                throw new InvalidMiddlewareDefinitionException([$this->class, $this->method]);
            }

            /**
             * @throws \ReflectionException
             *
             * @return \ReflectionParameter[]
             */
            private function getActionParameters(): array
            {
                return (new ReflectionClass($this->class))->getMethod($this->method)->getParameters();
            }

            public function __debugInfo()
            {
                return [
                    'callback' => [$this->class, $this->method],
                ];
            }
        };
    }
}

yiisoft / middleware-dispatcher

Pull Request — master (#68)

MiddlewareFactory.php$1 ➔ __construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
