| Total Lines | 81 |
| Code Lines | 42 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 184 | private function createCallableWrapper(callable $callback): MiddlewareInterface |
||
| 185 | 1 | { |
|
| 186 | return new class ( |
||
| 187 | 1 | $callback, |
|
| 188 | $this->container, |
||
| 189 | 11 | $this, |
|
| 190 | $this->eventDispatcher, |
||
| 191 | $this->parametersResolver, |
||
| 192 | ) implements MiddlewareInterface { |
||
| 193 | /** @var callable */ |
||
| 194 | private $callback; |
||
| 195 | /** |
||
| 196 | 6 | * @var ReflectionParameter[] |
|
| 197 | * @psalm-var array<string,ReflectionParameter> |
||
| 198 | 6 | */ |
|
| 199 | private array $callableParameters = []; |
||
| 200 | public array $middlewares; |
||
| 201 | |||
| 202 | public function __construct( |
||
| 203 | callable $callback, |
||
| 204 | private ContainerInterface $container, |
||
| 205 | private MiddlewareFactory $middlewareFactory, |
||
| 206 | private ?EventDispatcherInterface $eventDispatcher, |
||
| 207 | 6 | private ?ParametersResolverInterface $parametersResolver |
|
| 208 | ) { |
||
| 209 | $this->callback = $callback; |
||
| 210 | $callback = Closure::fromCallable($callback); |
||
| 211 | |||
| 212 | $reflectionFunction = new ReflectionFunction($callback); |
||
| 213 | |||
| 214 | 6 | $this->middlewares = array_map( |
|
| 215 | 6 | static fn (ReflectionAttribute $attribute) => $attribute->newInstance()->definition, |
|
| 216 | 6 | $reflectionFunction->getAttributes(Middleware::class) |
|
| 217 | 1 | ); |
|
| 218 | 1 | $callableParameters = $reflectionFunction->getParameters(); |
|
| 219 | 1 | foreach ($callableParameters as $parameter) { |
|
| 220 | 1 | $this->callableParameters[$parameter->getName()] = $parameter; |
|
| 221 | } |
||
| 222 | } |
||
| 223 | |||
| 224 | 6 | public function process( |
|
| 225 | 6 | ServerRequestInterface $request, |
|
| 226 | 5 | RequestHandlerInterface $handler |
|
| 227 | ): ResponseInterface { |
||
| 228 | $parameters = [$request, $handler]; |
||
| 229 | 1 | if ($this->parametersResolver !== null) { |
|
| 230 | $parameters = array_merge( |
||
| 231 | $parameters, |
||
| 232 | $this->parametersResolver->resolve($this->callableParameters, $request) |
||
| 233 | ); |
||
| 234 | } |
||
| 235 | |||
| 236 | if ($this->middlewares !== []) { |
||
| 237 | $middlewares = [...$this->middlewares, fn() => ($this->callback)()]; |
||
| 238 | $middlewareDispatcher = new MiddlewareDispatcher($this->middlewareFactory, $this->eventDispatcher); |
||
| 239 | 1 | $middlewareDispatcher = $middlewareDispatcher->withMiddlewares($middlewares); |
|
| 240 | $response = $middlewareDispatcher->dispatch($request, $handler); |
||
| 241 | } else { |
||
| 242 | /** @var MiddlewareInterface|mixed|ResponseInterface $response */ |
||
| 243 | $response = (new Injector($this->container))->invoke($this->callback, $parameters); |
||
| 244 | 1 | } |
|
| 245 | 1 | if ($response instanceof ResponseInterface) { |
|
| 246 | 1 | return $response; |
|
| 247 | } |
||
| 248 | 6 | if ($response instanceof MiddlewareInterface) { |
|
| 249 | return $response->process($request, $handler); |
||
| 250 | } |
||
| 251 | |||
| 252 | throw new InvalidMiddlewareDefinitionException($this->callback); |
||
| 253 | } |
||
| 254 | |||
| 255 | public function __debugInfo(): array |
||
| 256 | { |
||
| 257 | if (is_array($this->callback) |
||
| 258 | && isset($this->callback[0], $this->callback[1]) |
||
| 259 | && is_object($this->callback[0]) |
||
| 260 | && is_string($this->callback[1]) |
||
| 261 | ) { |
||
| 262 | return ['callback' => [$this->callback[0]::class, $this->callback[1]]]; |
||
| 263 | } |
||
| 264 | return ['callback' => $this->callback]; |
||
| 265 | } |
||
| 269 |