yiisoft /
http
| Conditions | 12 |
| Paths | 9 |
| Total Lines | 43 |
| Code Lines | 30 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 30 |
| CRAP Score | 12 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 29 | 12 | protected function collect(BaseHeaderValue $value): void |
|
| 30 | { |
||
| 31 | 12 | if (count($this->collection) === 0) { |
|
| 32 | 12 | $this->collection[] = $value; |
|
| 33 | 12 | return; |
|
| 34 | } |
||
| 35 | 11 | for ($pos = array_key_last($this->collection); $pos >= 0; --$pos) { |
|
| 36 | 11 | $item = $this->collection[$pos]; |
|
| 37 | 11 | $result = (float)$item->getQuality() <=> (float)$value->getQuality(); |
|
|
Bug
introduced
by
|
|||
| 38 | 11 | if ($result > 0) { |
|
| 39 | 5 | break; |
|
| 40 | } |
||
| 41 | 11 | if ($result === 0) { |
|
| 42 | 10 | $separator = $this->headerClass::VALUE_SEPARATOR; |
|
| 43 | 10 | if ($separator !== '') { |
|
| 44 | 6 | $itemTypes = array_reverse(explode($separator, $item->getValue())); |
|
| 45 | 6 | $valueTypes = array_reverse(explode($separator, $value->getValue())); |
|
| 46 | } else { |
||
| 47 | 4 | $itemTypes = [$item->getValue()]; |
|
| 48 | 4 | $valueTypes = [$value->getValue()]; |
|
| 49 | } |
||
| 50 | 10 | $result = count($itemTypes) <=> count($valueTypes); |
|
| 51 | 10 | if ($result > 0) { |
|
| 52 | 3 | break; |
|
| 53 | } |
||
| 54 | 10 | if ($result === 0) { |
|
| 55 | 9 | foreach ($itemTypes as $part => $itemType) { |
|
| 56 | 9 | if ($itemType === '*' xor $valueTypes[$part] === '*') { |
|
| 57 | 7 | if ($itemType !== '*') { |
|
| 58 | 4 | break 2; |
|
| 59 | } |
||
| 60 | 7 | $this->collection[$pos + 1] = $item; |
|
| 61 | 7 | continue 2; |
|
| 62 | } |
||
| 63 | } |
||
| 64 | 8 | if (count($item->getParams()) >= count($value->getParams())) { |
|
| 65 | 7 | break; |
|
| 66 | } |
||
| 67 | } |
||
| 68 | } |
||
| 69 | 8 | $this->collection[$pos + 1] = $item; |
|
| 70 | } |
||
| 71 | 11 | $this->collection[$pos + 1] = $value; |
|
| 72 | 11 | } |
|
| 74 |
Loading history...