Yiisoft\Http\Header\SortableHeader

Complexity

Total Complexity

6

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
A	collect()	0	16	4

<?php

declare(strict_types=1);

namespace Yiisoft\Http\Header;

use InvalidArgumentException;
use Yiisoft\Http\Header\Internal\BaseHeaderValue;
use Yiisoft\Http\Header\Internal\WithParamsHeaderValue;
use Yiisoft\Http\Header\Value\Unnamed\SortedValue;

final class SortableHeader extends Header
{
    protected const DEFAULT_VALUE_CLASS = SortedValue::class;

    public function __construct(string $nameOrClass)
    {
        parent::__construct($nameOrClass);
        if (!is_subclass_of($this->headerClass, WithParamsHeaderValue::class, true)) {
            throw new InvalidArgumentException(
                sprintf('%s class does not implement %s', $this->headerClass, WithParamsHeaderValue::class)
            );
        }
    }

    /**
     * Add value in order
     */
    protected function collect(BaseHeaderValue $value): void
    {
        if (count($this->collection) === 0) {
            $this->collection[] = $value;
            return;
        }
        for ($pos = array_key_last($this->collection); $pos >= 0; --$pos) {
            $item = $this->collection[$pos];
            $result = (float)$item->getQuality() <=> (float)$value->getQuality();

The method getQuality() does not exist on Yiisoft\Http\Header\Internal\BaseHeaderValue. It seems like you code against a sub-type of Yiisoft\Http\Header\Internal\BaseHeaderValue such as Yiisoft\Http\Header\Internal\WithParamsHeaderValue.

            if ($result >= 0) {
                $this->collection[$pos + 1] = $value;
                return;
            }
            $this->collection[$pos + 1] = $item;
        }
        $this->collection[0] = $value;
    }
}