| Conditions | 10 |
| Paths | 22 |
| Total Lines | 31 |
| Code Lines | 17 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 132 | protected function run(): string |
||
| 133 | { |
||
| 134 | $useModel = $this->hasFormModelAndAttribute(); |
||
| 135 | |||
| 136 | $content = $useModel |
||
| 137 | ? $this->content ?? $this->getFormAttributeLabel() |
||
| 138 | : (string) $this->content; |
||
| 139 | |||
| 140 | if ($content === '') { |
||
| 141 | return ''; |
||
| 142 | } |
||
| 143 | |||
| 144 | $labelAttributes = $this->attributes; |
||
| 145 | |||
| 146 | if ($this->setFor && !isset($labelAttributes['for'])) { |
||
| 147 | $id = $this->forId; |
||
| 148 | if ($useModel && $id === null && $this->useInputId) { |
||
| 149 | $id = $this->getInputId(); |
||
| 150 | } |
||
| 151 | if ($id !== null) { |
||
| 152 | $labelAttributes['for'] = $id; |
||
| 153 | } |
||
| 154 | } |
||
| 155 | |||
| 156 | $tag = Html::label($content)->attributes($labelAttributes); |
||
| 157 | |||
| 158 | if (!$this->encode) { |
||
| 159 | $tag = $tag->encode(false); |
||
| 160 | } |
||
| 161 | |||
| 162 | return $tag->render(); |
||
| 163 | } |
||
| 165 |