Yiisoft\Factory\ServiceLocator\ServiceLocator::__construct()

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function __construct(
        ContainerInterface $container = null,
        array $definitions = [],
        bool $validate = true
    ) {
        $this->dependencyResolver = new DependencyResolver($container);

        foreach ($definitions as $id => $definition) {
            if ($validate) {
                DefinitionValidator::validate($definition, $id);
            }
            $this->dependencyResolver->set($id, $definition);

It seems like $id can also be of type null; however, parameter $id of Yiisoft\Factory\ServiceLocator\DependencyResolver::set() does only seem to accept string, maybe add an additional type check?

        }