ParameterDefinition::resolve() - Code Metrics - Inspection of "Don't try set null to non-nullable dependencies +..." - yiisoft/factory - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#129)

by Sergei

created 2021-08-11 14:11 UTC

ParameterDefinition::resolve() A

↳ Parent: ParameterDefinition

Complexity

Conditions	4
Paths	4

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
dl	0
loc	15
c	1
b	0
f	0
ccs	8
cts	8
cp	1
rs	10
cc	4
nc	4
nop	1
crap	4

<?php

declare(strict_types=1);

namespace Yiisoft\Factory\Definition;

use ReflectionParameter;
use Yiisoft\Factory\DependencyResolverInterface;
use Yiisoft\Factory\Exception\NotInstantiableException;
use Yiisoft\Factory\Exception\NotDetermineDefaultValueOfPhpInternalException;

final class ParameterDefinition implements DefinitionInterface
{
    private ReflectionParameter $parameter;

    public function __construct(ReflectionParameter $parameter)
    {
        $this->parameter = $parameter;
    }

    public function isVariadic(): bool
    {
        return $this->parameter->isVariadic();
    }

    public function isOptional(): bool
    {
        return $this->parameter->isOptional();
    }

    public function hasValue(): bool
    {
        return $this->parameter->isDefaultValueAvailable() || $this->parameter->allowsNull();
    }

    public function resolve(DependencyResolverInterface $container)
    {
        if ($this->parameter->isDefaultValueAvailable()) {
            return $this->parameter->getDefaultValue();
        }

        if ($this->parameter->allowsNull()) {
            return null;
        }

        if ($this->isOptional()) {
            throw new NotDetermineDefaultValueOfPhpInternalException($this->parameter);
        }

        throw new NotInstantiableException('Parameter definition does not contain a value.');
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Factory\Definition;
6
7		use ReflectionParameter;
8		use Yiisoft\Factory\DependencyResolverInterface;
9		use Yiisoft\Factory\Exception\NotInstantiableException;
10		use Yiisoft\Factory\Exception\NotDetermineDefaultValueOfPhpInternalException;
11
12		final class ParameterDefinition implements DefinitionInterface
13		{
14		private ReflectionParameter $parameter;
15
16	17	public function __construct(ReflectionParameter $parameter)
17		{
18	17	$this->parameter = $parameter;
19	17	}
20
21	63	public function isVariadic(): bool
22		{
23	63	return $this->parameter->isVariadic();
24		}
25
26	45	public function isOptional(): bool
27		{
28	45	return $this->parameter->isOptional();
29		}
30
31	41	public function hasValue(): bool
32		{
33	41	return $this->parameter->isDefaultValueAvailable() \|\| $this->parameter->allowsNull();
34		}
35
36	46	public function resolve(DependencyResolverInterface $container)
37		{
38	46	if ($this->parameter->isDefaultValueAvailable()) {
39	42	return $this->parameter->getDefaultValue();
40		}
41
42	4	if ($this->parameter->allowsNull()) {
43	2	return null;
44		}
45
46	2	if ($this->isOptional()) {
47	1	throw new NotDetermineDefaultValueOfPhpInternalException($this->parameter);
48		}
49
50	1	throw new NotInstantiableException('Parameter definition does not contain a value.');
51		}
52		}
53

yiisoft / factory

Pull Request — master (#129)

ParameterDefinition::resolve() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like