Yiisoft\Factory\Definitions\ArrayDefinition

Complexity

Total Complexity

12

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Test Coverage

Coverage

93.94%

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	resolve()	0	3	1
A	getBuilder()	0	7	2
A	getConfig()	0	3	1
A	mergeParameters()	0	7	2
A	merge()	0	6	1
A	getClass()	0	3	1
A	getParams()	0	3	1
A	fromArray()	0	12	2
A	__construct()	0	5	1

<?php

declare(strict_types=1);

namespace Yiisoft\Factory\Definitions;

use Psr\Container\ContainerInterface;
use Yiisoft\Factory\Exceptions\InvalidConfigException;

/**
 * Builds object by array config
 */
class ArrayDefinition implements DefinitionInterface
{
    private const CLASS_KEY = '__class';
    private const PARAMS_KEY = '__construct()';

    /**
     * @var class-string

The doc comment class-string at position 0 could not be parsed: Unknown type name 'class-string' at position 0 in class-string.

     */
    private string $class;
    private array $params;
    private array $config;
    private static ?ArrayBuilder $builder = null;

    /**
     * @param class-string $class

The doc comment class-string at position 0 could not be parsed: Unknown type name 'class-string' at position 0 in class-string.

     * @param array $params
     * @param array $config
     */
    public function __construct(string $class, array $params = [], array $config = [])
    {
        $this->class  = $class;
        $this->params = $params;
        $this->config = $config;
    }

    /**
     * @return class-string

The doc comment class-string at position 0 could not be parsed: Unknown type name 'class-string' at position 0 in class-string.

     */
    public function getClass(): string
    {
        return $this->class;
    }

    public function getParams(): array
    {
        return $this->params;
    }

    public function getConfig(): array
    {
        return $this->config;
    }

    public static function fromArray(string $class = null, array $params = [], array $config = []): self
    {
        $class  = $config[self::CLASS_KEY] ?? $class;
        $params = $config[self::PARAMS_KEY] ?? $params;

        unset($config[self::CLASS_KEY], $config[self::PARAMS_KEY]);

        if (empty($class)) {
            throw new InvalidConfigException('Invalid definition: empty class name.');
        }

        return new self($class, $params, $config);
    }

    public function resolve(ContainerInterface $container)
    {
        return $this->getBuilder()->build($container, $this);
    }

    private function getBuilder(): ArrayBuilder
    {
        if (static::$builder === null) {

Since $builder is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $builder to at least protected.

            static::$builder = new ArrayBuilder();
        }

        return static::$builder;

The expression return static::builder could return the type null which is incompatible with the type-hinted return Yiisoft\Factory\Definitions\ArrayBuilder. Consider adding an additional type-check to rule them out.

    }

    public function merge(self $other): self
    {
        return new self(
            $other->class,
            $this->mergeParameters($this->params, $other->params),
            array_merge($this->config, $other->config)
        );
    }

    private function mergeParameters(array $selfParameters, array $otherParameters): array
    {
        foreach ($otherParameters as $index => $param) {
            $selfParameters[$index] = $otherParameters[$index];
        }

        return $selfParameters;
    }
}