Yiisoft\Di\CompositeContainer::get()

Complexity

Conditions	14
Paths	27

Size

Total Lines	62
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	33
CRAP Score	14.0364

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function get($id)
    {
        /** @psalm-suppress TypeDoesNotContainType */
        if (!is_string($id)) {

The condition is_string($id) is always true.

            throw new InvalidArgumentException("Id must be a string, {$this->getVariableType($id)} given.");
        }

        if ($id === StateResetter::class) {
            $resetters = [];
            foreach ($this->containers as $container) {
                if ($container->has(StateResetter::class)) {
                    $resetters[] = $container->get(StateResetter::class);
                }
            }
            $stateResetter = new StateResetter($this);
            $stateResetter->setResetters($resetters);

            return $stateResetter;
        }

        if ($this->isTagAlias($id)) {
            $tags = [];
            foreach ($this->containers as $container) {
                if (!$container instanceof Container) {
                    continue;
                }
                if ($container->has($id)) {
                    /** @psalm-suppress MixedArgument Container::get() always return array for tag */
                    $tags = array_merge($container->get($id), $tags);

It seems like $container->get($id) can also be of type object; however, parameter $arrays of array_merge() does only seem to accept array, maybe add an additional type check?

                }
            }

            return $tags;
        }

        foreach ($this->containers as $container) {
            if ($container->has($id)) {
                /** @psalm-suppress MixedReturnStatement */
                return $container->get($id);
            }
        }

        // Collect details from containers
        $exceptions = [];
        foreach ($this->containers as $container) {
            $hasException = false;
            try {
                $container->get($id);
            } catch (Throwable $t) {
                $hasException = true;
                $exceptions[] = [$t, $container];
            } finally {
                if (!$hasException) {
                    $exceptions[] = [
                        new RuntimeException('Container has() returned false but no exception was thrown from get().'),
                        $container
                    ];
                }
            }
        }

        throw new CompositeNotFoundException($exceptions);
    }