DefinitionParser::parse() - Code Metrics - Inspection of "Refactoring" - yiisoft/di - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#212)

by Sergei

created 2021-05-13 21:02 UTC

DefinitionParser::parse() B

↳ Parent: DefinitionParser

Complexity

Conditions	9
Paths	9

Size

Total Lines	57
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	9
eloc	32
c	4
b	0
f	0
nc	9
nop	1
dl	0
loc	57
rs	8.0555

How to fix Long Method

<?php

declare(strict_types=1);

namespace Yiisoft\Di;

use Yiisoft\Factory\Definition\ArrayDefinition;
use Yiisoft\Factory\Exception\InvalidConfigException;

use function is_array;
use function is_callable;

/**
 * @internal Splits metadata and definition.
 *
 * Supports the following configuration:
 *
 * 1) With a dedicated definition:
 *
 * ```php
 * Engine::class => [
 *     'definition' => [
 *         '__class' => BigEngine::class,
 *         'setNumber()' => [42],
 *     ],
 *     'tags' => ['a', 'b'],
 *     'reset' => function () {
 *         $this->number = 42;
 *      },
 * ]
 * ```
 *
 * 2) Mixed in array definition:
 *
 * ```php
 * Engine::class => [
 *     '__class' => BigEngine::class,
 *     'setNumber()' => [42],
 *     'tags' => ['a', 'b'],
 *     'reset' => function () {
 *         $this->number = 42;
 *      },
 * ]
 * ```
 */
final class DefinitionParser
{
    private const DEFINITION_META = 'definition';

    public const IS_PREPARED_ARRAY_DEFINITION_DATA = 'isPreparedArrayDefinitionData';

    /**
     * @param mixed $definition
     *
     * @throws InvalidConfigException
     */
    public static function parse($definition): array
    {
        if (!is_array($definition)) {
            return [$definition, []];
        }

        // Dedicated definition
        if (isset($definition[self::DEFINITION_META])) {
            $newDefinition = $definition[self::DEFINITION_META];
            unset($definition[self::DEFINITION_META]);

            return [$newDefinition, $definition];
        }

        // Callable definition
        if (is_callable($definition, true)) {
            return [$definition, []];
        }

        // Array definition
        $meta = [];
        $class = null;
        $constructorArguments = [];
        $methodsAndProperties = [];
        foreach ($definition as $key => $value) {
            // Class
            if ($key === ArrayDefinition::CLASS_NAME) {
                $class = $value;
                continue;
            }

            // Constructor arguments
            if ($key === ArrayDefinition::CONSTRUCTOR) {
                $constructorArguments = $value;
                continue;
            }

            // Methods and properties
            if (substr($key, -2) === '()') {
                $methodsAndProperties[$key] = [ArrayDefinition::TYPE_METHOD, $key, $value];

                continue;
            }
            if (strncmp($key, '$', 1) === 0) {
                $methodsAndProperties[$key] = [ArrayDefinition::TYPE_PROPERTY, $key, $value];

                continue;
            }

            $meta[$key] = $value;
        }
        return [
            [
                $class,
                $constructorArguments,
                $methodsAndProperties,
                self::IS_PREPARED_ARRAY_DEFINITION_DATA => true,
            ],
            $meta,
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Di;
6
7			use Yiisoft\Factory\Definition\ArrayDefinition;
8			use Yiisoft\Factory\Exception\InvalidConfigException;
9
10			use function is_array;
11			use function is_callable;
12
13			/**
14			* @internal Splits metadata and definition.
15			*
16			* Supports the following configuration:
17			*
18			* 1) With a dedicated definition:
19			*
20			* ```php
21			* Engine::class => [
22			* 'definition' => [
23			* '__class' => BigEngine::class,
24			* 'setNumber()' => [42],
25			* ],
26			* 'tags' => ['a', 'b'],
27			* 'reset' => function () {
28			* $this->number = 42;
29			* },
30			* ]
31			* ```
32			*
33			* 2) Mixed in array definition:
34			*
35			* ```php
36			* Engine::class => [
37			* '__class' => BigEngine::class,
38			* 'setNumber()' => [42],
39			* 'tags' => ['a', 'b'],
40			* 'reset' => function () {
41			* $this->number = 42;
42			* },
43			* ]
44			* ```
45			*/
46			final class DefinitionParser
47			{
48			private const DEFINITION_META = 'definition';
49
50			public const IS_PREPARED_ARRAY_DEFINITION_DATA = 'isPreparedArrayDefinitionData';
51
52			/**
53			* @param mixed $definition
54			*
55			* @throws InvalidConfigException
56			*/
57			public static function parse($definition): array
58			{
59			if (!is_array($definition)) {
60			return [$definition, []];
61			}
62
63			// Dedicated definition
64			if (isset($definition[self::DEFINITION_META])) {
65			$newDefinition = $definition[self::DEFINITION_META];
66			unset($definition[self::DEFINITION_META]);
67
68			return [$newDefinition, $definition];
69			}
70
71			// Callable definition
72			if (is_callable($definition, true)) {
73			return [$definition, []];
74			}
75
76			// Array definition
77			$meta = [];
78			$class = null;
79			$constructorArguments = [];
80			$methodsAndProperties = [];
81			foreach ($definition as $key => $value) {
82			// Class
83			if ($key === ArrayDefinition::CLASS_NAME) {
84			$class = $value;
85			continue;
86			}
87
88			// Constructor arguments
89			if ($key === ArrayDefinition::CONSTRUCTOR) {
90			$constructorArguments = $value;
91			continue;
92			}
93
94			// Methods and properties
95			if (substr($key, -2) === '()') {
96			$methodsAndProperties[$key] = [ArrayDefinition::TYPE_METHOD, $key, $value];
			0 ignored issues – show Bug introduced 2021-05-13 21:05 UTC by Report Bug Copy Issue Report The constant `Yiisoft\Factory\Definiti...Definition::TYPE_METHOD` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
97			continue;
98			}
99			if (strncmp($key, '$', 1) === 0) {
100			$methodsAndProperties[$key] = [ArrayDefinition::TYPE_PROPERTY, $key, $value];
			0 ignored issues – show Bug introduced 2021-05-13 21:05 UTC by Report Bug Copy Issue Report The constant `Yiisoft\Factory\Definiti...finition::TYPE_PROPERTY` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
101			continue;
102			}
103
104			$meta[$key] = $value;
105			}
106			return [
107			[
108			$class,
109			$constructorArguments,
110			$methodsAndProperties,
111			self::IS_PREPARED_ARRAY_DEFINITION_DATA => true,
112			],
113			$meta,
114			];
115			}
116			}
117

yiisoft / di

Pull Request — master (#212)

DefinitionParser::parse() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like