yiisoft /
di
| Conditions | 10 |
| Paths | 10 |
| Total Lines | 32 |
| Code Lines | 18 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 18 |
| CRAP Score | 10.0145 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 23 | 28 | public function get($id) |
|
| 24 | { |
||
| 25 | 28 | if ($id === StateResetter::class) { |
|
| 26 | 2 | $resetters = []; |
|
| 27 | 2 | foreach ($this->containers as $container) { |
|
| 28 | 2 | if ($container->has(StateResetter::class)) { |
|
| 29 | 2 | $resetters[] = $container->get(StateResetter::class); |
|
| 30 | } |
||
| 31 | } |
||
| 32 | 2 | return new StateResetter($resetters, $this); |
|
| 33 | } |
||
| 34 | |||
| 35 | 28 | if ($this->isTagAlias($id)) { |
|
| 36 | 2 | $tags = []; |
|
| 37 | 2 | foreach ($this->containers as $container) { |
|
| 38 | 2 | if (!$container instanceof Container) { |
|
| 39 | continue; |
||
| 40 | } |
||
| 41 | 2 | if ($container->has($id)) { |
|
| 42 | 2 | $tags = array_merge($container->get($id), $tags); |
|
|
Bug
introduced
by
|
|||
| 43 | } |
||
| 44 | } |
||
| 45 | |||
| 46 | 2 | return $tags; |
|
| 47 | } |
||
| 48 | |||
| 49 | 26 | foreach ($this->containers as $container) { |
|
| 50 | 26 | if ($container->has($id)) { |
|
| 51 | 22 | return $container->get($id); |
|
| 52 | } |
||
| 53 | } |
||
| 54 | 6 | throw new NotFoundException($id); |
|
| 55 | } |
||
| 96 |
Loading history...