DefinitionParser::parse() - Code Metrics - Inspection of "Refactoring" - yiisoft/di - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#212)

by Sergei

created 2021-05-21 17:41 UTC

DefinitionParser::parse() B

↳ Parent: DefinitionParser

Complexity

Conditions	9
Paths	9

Size

Total Lines	57
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
cc	9
eloc	32
c	5
b	0
f	0
nc	9
nop	1
dl	0
loc	57
rs	8.0555

How to fix Long Method

<?php

declare(strict_types=1);

namespace Yiisoft\Di;

use Yiisoft\Factory\Definition\ArrayDefinition;
use Yiisoft\Factory\Exception\InvalidConfigException;

use function count;
use function is_array;
use function is_callable;

/**
 * @internal Splits metadata and definition.
 *
 * Supports the following configuration:
 *
 * 1) With a dedicated definition:
 *
 * ```php
 * Engine::class => [
 *     'definition' => [
 *         '__class' => BigEngine::class,
 *         'setNumber()' => [42],
 *     ],
 *     'tags' => ['a', 'b'],
 *     'reset' => function () {
 *         $this->number = 42;
 *      },
 * ]
 * ```
 *
 * 2) Mixed in array definition:
 *
 * ```php
 * Engine::class => [
 *     '__class' => BigEngine::class,
 *     'setNumber()' => [42],
 *     'tags' => ['a', 'b'],
 *     'reset' => function () {
 *         $this->number = 42;
 *      },
 * ]
 * ```
 */
final class DefinitionParser
{
    private const DEFINITION_META = 'definition';

    public const IS_PREPARED_ARRAY_DEFINITION_DATA = 'isPreparedArrayDefinitionData';

    /**
     * @param mixed $definition
     *
     * @throws InvalidConfigException
     */
    public static function parse($definition): array
    {
        if (!is_array($definition)) {
            return [$definition, []];
        }

        // Dedicated definition
        if (isset($definition[self::DEFINITION_META])) {
            $newDefinition = $definition[self::DEFINITION_META];
            unset($definition[self::DEFINITION_META]);

            return [$newDefinition, $definition];
        }

        // Callable definition
        if (is_callable($definition, true)) {
            return [$definition, []];
        }

        // Array definition
        $meta = [];
        $class = null;
        $constructorArguments = [];
        $methodsAndProperties = [];
        foreach ($definition as $key => $value) {
            // Class
            if ($key === ArrayDefinition::CLASS_NAME) {
                $class = $value;
                continue;
            }

            // Constructor arguments
            if ($key === ArrayDefinition::CONSTRUCTOR) {
                $constructorArguments = $value;
                continue;
            }

            // Methods and properties
            if (count($methodArray = explode('()', $key)) === 2) {
                $methodsAndProperties[$key] = [ArrayDefinition::TYPE_METHOD, $methodArray[0], $value];

                continue;
            }
            if (count($propertyArray = explode('$', $key)) === 2) {
                $methodsAndProperties[$key] = [ArrayDefinition::TYPE_PROPERTY, $propertyArray[1], $value];

                continue;
            }

            $meta[$key] = $value;
        }
        return [
            [
                $class,
                $constructorArguments,
                $methodsAndProperties,
                self::IS_PREPARED_ARRAY_DEFINITION_DATA => true,
            ],
            $meta,
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Di;
6
7			use Yiisoft\Factory\Definition\ArrayDefinition;
8			use Yiisoft\Factory\Exception\InvalidConfigException;
9
10			use function count;
11			use function is_array;
12			use function is_callable;
13
14			/**
15			* @internal Splits metadata and definition.
16			*
17			* Supports the following configuration:
18			*
19			* 1) With a dedicated definition:
20			*
21			* ```php
22			* Engine::class => [
23			* 'definition' => [
24			* '__class' => BigEngine::class,
25			* 'setNumber()' => [42],
26			* ],
27			* 'tags' => ['a', 'b'],
28			* 'reset' => function () {
29			* $this->number = 42;
30			* },
31			* ]
32			* ```
33			*
34			* 2) Mixed in array definition:
35			*
36			* ```php
37			* Engine::class => [
38			* '__class' => BigEngine::class,
39			* 'setNumber()' => [42],
40			* 'tags' => ['a', 'b'],
41			* 'reset' => function () {
42			* $this->number = 42;
43			* },
44			* ]
45			* ```
46			*/
47			final class DefinitionParser
48			{
49			private const DEFINITION_META = 'definition';
50
51			public const IS_PREPARED_ARRAY_DEFINITION_DATA = 'isPreparedArrayDefinitionData';
52
53			/**
54			* @param mixed $definition
55			*
56			* @throws InvalidConfigException
57			*/
58			public static function parse($definition): array
59			{
60			if (!is_array($definition)) {
61			return [$definition, []];
62			}
63
64			// Dedicated definition
65			if (isset($definition[self::DEFINITION_META])) {
66			$newDefinition = $definition[self::DEFINITION_META];
67			unset($definition[self::DEFINITION_META]);
68
69			return [$newDefinition, $definition];
70			}
71
72			// Callable definition
73			if (is_callable($definition, true)) {
74			return [$definition, []];
75			}
76
77			// Array definition
78			$meta = [];
79			$class = null;
80			$constructorArguments = [];
81			$methodsAndProperties = [];
82			foreach ($definition as $key => $value) {
83			// Class
84			if ($key === ArrayDefinition::CLASS_NAME) {
85			$class = $value;
86			continue;
87			}
88
89			// Constructor arguments
90			if ($key === ArrayDefinition::CONSTRUCTOR) {
91			$constructorArguments = $value;
92			continue;
93			}
94
95			// Methods and properties
96			if (count($methodArray = explode('()', $key)) === 2) {
97			$methodsAndProperties[$key] = [ArrayDefinition::TYPE_METHOD, $methodArray[0], $value];
			0 ignored issues – show Bug introduced 2021-05-13 21:05 UTC by Report Bug Copy Issue Report The constant `Yiisoft\Factory\Definiti...Definition::TYPE_METHOD` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
98			continue;
99			}
100			if (count($propertyArray = explode('$', $key)) === 2) {
101			$methodsAndProperties[$key] = [ArrayDefinition::TYPE_PROPERTY, $propertyArray[1], $value];
			0 ignored issues – show Bug introduced 2021-05-13 21:05 UTC by Report Bug Copy Issue Report The constant `Yiisoft\Factory\Definiti...finition::TYPE_PROPERTY` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
102			continue;
103			}
104
105			$meta[$key] = $value;
106			}
107			return [
108			[
109			$class,
110			$constructorArguments,
111			$methodsAndProperties,
112			self::IS_PREPARED_ARRAY_DEFINITION_DATA => true,
113			],
114			$meta,
115			];
116			}
117			}
118

yiisoft / di

Pull Request — master (#212)

DefinitionParser::parse() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like