App\Auth\Controller\ChangePasswordController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Importance

Changes	4
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	1
B	change()	0	36	7
A	redirectToMain()	0	3	1
A	flash_message()	0	3	1

<?php
declare(strict_types=1);

namespace App\Auth\Controller;

use App\Auth\AuthService;
use App\Auth\Identity;
use App\Auth\IdentityRepository;
use App\Auth\Form\ChangePasswordForm;
use App\Service\WebControllerService;
use Psr\Http\Message\ResponseInterface;

The type Psr\Http\Message\ResponseInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use Psr\Http\Message\ServerRequestInterface;

The type Psr\Http\Message\ServerRequestInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\FormModel\FormHydrator;

The type Yiisoft\FormModel\FormHydrator was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\Http\Method;

The type Yiisoft\Http\Method was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\Session\SessionInterface as Session;

The type Yiisoft\Session\SessionInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\Session\Flash\Flash;

The type Yiisoft\Session\Flash\Flash was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\Translator\TranslatorInterface as Translator;

The type Yiisoft\Translator\TranslatorInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\User\CurrentUser;

The type Yiisoft\User\CurrentUser was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\Yii\View\ViewRenderer;

The type Yiisoft\Yii\View\ViewRenderer was not found. Maybe you did not declare it correctly or list all dependencies?

final class ChangePasswordController
{
    public function __construct(
      private Session $session,
      private Flash $flash,
      private Translator $translator,
      private CurrentUser $currentUser,
      private WebControllerService $webService, 
      private ViewRenderer $viewRenderer,
    )
    {
      $this->currentUser = $currentUser;
      $this->session = $session;      
      $this->flash = new Flash($session);
      $this->translator = $translator;
      $this->viewRenderer = $viewRenderer->withControllerName('changepassword');
    }
    
    public function change(
      AuthService $authService,
      Identity $identity,
      IdentityRepository $identityRepository,
      ServerRequestInterface $request,
      FormHydrator $formHydrator,
      ChangePasswordForm $changePasswordForm
    ): ResponseInterface {
      if ($authService->isGuest()) {
          return $this->redirectToMain();
      }
     
      $identity_id = $this->currentUser->getIdentity()->getId();
      if (null!==$identity_id) {
        $identity = $identityRepository->findIdentity($identity_id);
        if (null!==$identity) {
          // Identity and User are in a HasOne relationship so no null value
          $login = $identity->getUser()?->getLogin();
          if ($request->getMethod() === Method::POST
            && $formHydrator->populate($changePasswordForm, $request->getParsedBody())
            && $changePasswordForm->change() 
          ) {
            // Identity implements CookieLoginIdentityInterface: ensure the regeneration of the cookie auth key by means of $authService->logout();
            // @see vendor\yiisoft\user\src\Login\Cookie\CookieLoginIdentityInterface 
            // Specific note: "Make sure to invalidate earlier issued keys when you implement force user logout,
            // PASSWORD CHANGE and other scenarios, that require forceful access revocation for old sessions.
            // The authService logout function will regenerate the auth key here => overwriting any auth key
            $authService->logout();
            $this->flash_message('success', $this->translator->translate('validator.password.change'));
            return $this->redirectToMain();
          }
          return $this->viewRenderer->render('change', 
                  [
                      'formModel' => $changePasswordForm, 
                      'login' => $login,
                      'canChangePasswordForAnyUser' => $this->currentUser->can('changePasswordForAnyUser')    
                  ]);
        } // identity

The function implicitly returns null when the if condition on line 54 is false. This is incompatible with the type-hinted return Psr\Http\Message\ResponseInterface. Consider adding a return statement or allowing null as return value.

      } // identity_id 

The function implicitly returns null when the if condition on line 52 is false. This is incompatible with the type-hinted return Psr\Http\Message\ResponseInterface. Consider adding a return statement or allowing null as return value.

    } // reset
    
    /**
     * @param string $level
     * @param string $message
     * @return Flash
     */
    private function flash_message(string $level, string $message): Flash {
      $this->flash->add($level, $message, true);
      return $this->flash;
    }
    
    private function redirectToMain(): ResponseInterface
    {
      return $this->webService->getRedirectResponse('site/index');
    }
}