App\Controller\SignupController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	signup()	0	41	5

<?php

declare(strict_types=1);

namespace App\Controller;

use App\Form\LoginForm;
use App\User\User;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ResponseInterface;
use Yiisoft\Auth\IdentityRepositoryInterface;
use Yiisoft\Http\Method;
use Yiisoft\Router\UrlGeneratorInterface;
use Yiisoft\Validator\ValidatorInterface;
use Yiisoft\Yii\Cycle\Data\Writer\EntityWriter;
use Yiisoft\Yii\View\ViewRenderer;

final class SignupController
{
    private ViewRenderer $viewRenderer;

    public function __construct(ViewRenderer $viewRenderer)
    {
        $this->viewRenderer = $viewRenderer->withControllerName('signup');
    }

    public function signup(
        EntityWriter $entityWriter,
        IdentityRepositoryInterface $identityRepository,
        LoginForm $loginForm,
        RequestInterface $request,
        ResponseFactoryInterface $responseFactory,
        UrlGeneratorInterface $urlGenerator,
        ValidatorInterface $validator
    ): ResponseInterface {
        $body = $request->getParsedBody();

The method getParsedBody() does not exist on Psr\Http\Message\RequestInterface. It seems like you code against a sub-type of Psr\Http\Message\RequestInterface such as Psr\Http\Message\ServerRequestInterface or GuzzleHttp\Psr7\ServerRequest.

        $error = null;

        if (
            $request->getMethod() === Method::POST
            && $loginForm->load($body)
            && $validator->validate($loginForm)->isValid()
        ) {
            /** @var User $identity */
            $identity = $identityRepository->findByLogin($loginForm->getAttributeValue('login'));

            if ($identity !== null) {
                $loginForm->getFormErrors()->addError('password', 'Unable to register user with such username.');
            } else {
                $user = new User($loginForm->getAttributeValue('login'), $loginForm->getAttributeValue('password'));

It seems like $loginForm->getAttributeValue('login') can also be of type boolean and iterable and null; however, parameter $login of App\User\User::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $loginForm->getAttributeValue('password') can also be of type boolean and iterable and null; however, parameter $password of App\User\User::__construct() does only seem to accept string, maybe add an additional type check?

                $entityWriter->write([$user]);

                return $responseFactory
                    ->createResponse(302)
                    ->withHeader(
                        'Location',
                        $urlGenerator->generate('site/index')
                    );
            }
        }

        return $this->viewRenderer->render(
            'signup',
            [
                'body' => $body,
                'formModel' => $loginForm,
                'error' => $error,
            ]
        );
    }
}