App\Blog\Post\PostController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	10	2
A	__construct()	0	7	1
A	add()	0	21	3
A	edit()	0	36	4

<?php

declare(strict_types=1);

namespace App\Blog\Post;

use App\Blog\Entity\Post;
use App\Service\WebControllerService;
use App\User\UserService;
use Psr\Http\Message\ResponseInterface as Response;

The type Psr\Http\Message\ResponseInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use Psr\Http\Message\ServerRequestInterface as Request;

The type Psr\Http\Message\ServerRequestInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\FormModel\FormHydrator;

The type Yiisoft\FormModel\FormHydrator was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\Http\Method;

The type Yiisoft\Http\Method was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\Router\CurrentRoute;

The type Yiisoft\Router\CurrentRoute was not found. Maybe you did not declare it correctly or list all dependencies?

use Yiisoft\Yii\View\Renderer\ViewRenderer;

The type Yiisoft\Yii\View\Renderer\ViewRenderer was not found. Maybe you did not declare it correctly or list all dependencies?

final class PostController
{
    public function __construct(
        private WebControllerService $webService,
        private PostService $postService,
        private UserService $userService,
        private ViewRenderer $viewRenderer,
    ) {
        $this->viewRenderer = $viewRenderer->withControllerName('blog/post');
    }

    public function index(CurrentRoute $currentRoute, PostRepository $postRepository): Response
    {
        $canEdit = $this->userService->hasPermission('editPost');
        $slug = $currentRoute->getArgument('slug');
        $item = $postRepository->fullPostPage($slug);
        if ($item === null) {
            return $this->webService->getNotFoundResponse();
        }

        return $this->viewRenderer->render('index', ['item' => $item, 'canEdit' => $canEdit, 'slug' => $slug]);
    }

    public function add(Request $request, FormHydrator $formHydrator): Response
    {
        $parameters = [
            'title' => 'Add post',
            'action' => ['blog/add'],
            'errors' => [],
            'body' => $request->getParsedBody(),
        ];

        if ($request->getMethod() === Method::POST) {
            $form = new PostForm();
            if ($formHydrator->populateAndValidate($form, $parameters['body'])) {
                $this->postService->savePost($this->userService->getUser(), new Post(), $form);

It seems like $this->userService->getUser() can also be of type null; however, parameter $user of App\Blog\Post\PostService::savePost() does only seem to accept App\User\User, maybe add an additional type check?

                return $this->webService->getRedirectResponse('blog/index');
            }

            $parameters['errors'] = $form->getValidationResult()->getErrorMessagesIndexedByProperty();
        }

        return $this->viewRenderer->render('__form', $parameters);
    }

    public function edit(
        Request $request,
        PostRepository $postRepository,
        CurrentRoute $currentRoute,
        FormHydrator $formHydrator
    ): Response {
        $slug = $currentRoute->getArgument('slug');
        $post = $postRepository->fullPostPage($slug);
        if ($post === null) {
            return $this->webService->getNotFoundResponse();
        }

        $parameters = [
            'title' => 'Edit post',
            'action' => ['blog/edit', ['slug' => $slug]],
            'errors' => [],
            'body' => [
                'title' => $post->getTitle(),
                'content' => $post->getContent(),
                'tags' => $this->postService->getPostTags($post),
            ],
        ];

        if ($request->getMethod() === Method::POST) {
            $form = new PostForm();
            $body = $request->getParsedBody();
            if ($formHydrator->populateAndValidate($form, $body)) {
                $this->postService->savePost($this->userService->getUser(), $post, $form);

It seems like $this->userService->getUser() can also be of type null; however, parameter $user of App\Blog\Post\PostService::savePost() does only seem to accept App\User\User, maybe add an additional type check?

                return $this->webService->getRedirectResponse('blog/index');
            }

            $parameters['body'] = $body;
            $parameters['errors'] = $form->getValidationResult()->getErrorMessagesIndexedByProperty();
        }

        return $this->viewRenderer->render('__form', $parameters);
    }
}