App\Infrastructure\Http\Response\ApiResponseDataFactory::createFromResponse()

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes

0

<?php
    public function createFromResponse(DataResponse $response): ApiResponse
    {
        if ($response->getStatusCode() !== Status::OK) {
            return $this
                ->createErrorResponse()
                ->setErrorCode($response->getStatusCode())
                ->setErrorMessage($this->getErrorMessage($response));
        }

        return $this
            ->createSuccessResponse()
            ->setData($response->getData());

It seems like $response->getData() can also be of type object; however, parameter $data of App\Infrastructure\Http\Response\ApiResponse::setData() does only seem to accept array|null, maybe add an additional type check?

    }