App\Infrastructure\Http\Response\ApiResponseDataFactory

Complexity

Total Complexity

8

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Test Coverage

Coverage

94.44%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	createSuccessResponse()	0	3	1
A	createResponse()	0	3	1
A	getErrorMessage()	0	8	3
A	createErrorResponse()	0	3	1
A	createFromResponse()	0	10	2

<?php

declare(strict_types=1);

namespace App\Infrastructure\Http\Response;

use Yiisoft\DataResponse\DataResponse;
use Yiisoft\Http\Status;

final class ApiResponseDataFactory
{
    public function createFromResponse(DataResponse $response): ApiResponse
    {
        if ($response->getStatusCode() !== Status::OK) {
            return $this->createErrorResponse()
                ->setErrorCode($response->getStatusCode())
                ->setErrorMessage($this->getErrorMessage($response));
        }

        return $this->createSuccessResponse()
            ->setData($response->getData());

It seems like $response->getData() can also be of type object; however, parameter $data of App\Infrastructure\Http\Response\ApiResponse::setData() does only seem to accept array|null, maybe add an additional type check?

    }

    public function createSuccessResponse(): ApiResponse
    {
        return $this->createResponse()->setStatus('success');
    }

    public function createErrorResponse(): ApiResponse
    {
        return $this->createResponse()->setStatus('failed');
    }

    public function createResponse(): ApiResponse
    {
        return new ApiResponse();
    }

    private function getErrorMessage(DataResponse $response): string
    {
        $data = $response->getData();
        if (is_string($data) && !empty($data)) {
            return $data;
        }

        return 'Unknown error';
    }
}