UserService::login() - Code Metrics - Inspection of "Restructure" - yiisoft/demo-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#87)

by Dmitriy

created 2022-02-19 13:41 UTC

UserService::login() A

↳ Parent: UserService

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4.3244

Importance

Changes

Metric	Value
cc	4
eloc	10
nc	4
nop	2
dl	0
loc	18
ccs	8
cts	11
cp	0.7272
crap	4.3244
rs	9.9332
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace App\Application\User\Service;

use App\Application\Exception\BadRequestException;
use App\Application\User\Entity\User;
use Yiisoft\Auth\IdentityInterface;
use Yiisoft\Auth\IdentityRepositoryInterface;
use Yiisoft\User\CurrentUser;

final class UserService
{
    private IdentityRepositoryInterface $identityRepository;
    private CurrentUser $currentUser;

    public function __construct(CurrentUser $currentUser, IdentityRepositoryInterface $identityRepository)
    {
        $this->currentUser = $currentUser;
        $this->identityRepository = $identityRepository;
    }

    /**
     * @param string $login
     * @param string $password
     *
     * @throws BadRequestException
     */
    public function login(string $login, string $password): IdentityInterface
    {
        $identity = $this->identityRepository->findByLogin($login);
        if ($identity === null) {
            throw new BadRequestException('No such user.');
        }

        if (!$identity->validatePassword($password)) {
            throw new BadRequestException('Invalid password.');
        }

        if (!$this->currentUser->login($identity)) {
            throw new BadRequestException();
        }

        $identity->resetToken();
        $this->identityRepository->save($identity);
        return $identity;
    }

    public function logout(User $user): void
    {
        $user->resetToken();
        $this->identityRepository->save($user);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace App\Application\User\Service;
6
7		use App\Application\Exception\BadRequestException;
8		use App\Application\User\Entity\User;
9		use Yiisoft\Auth\IdentityInterface;
10		use Yiisoft\Auth\IdentityRepositoryInterface;
11		use Yiisoft\User\CurrentUser;
12
13		final class UserService
14		{
15		private IdentityRepositoryInterface $identityRepository;
16		private CurrentUser $currentUser;
17
18	2	public function __construct(CurrentUser $currentUser, IdentityRepositoryInterface $identityRepository)
19		{
20	2	$this->currentUser = $currentUser;
21	2	$this->identityRepository = $identityRepository;
22		}
23
24		/**
25		* @param string $login
26		* @param string $password
27		*
28		* @throws BadRequestException
29		*/
30	1	public function login(string $login, string $password): IdentityInterface
31		{
32	1	$identity = $this->identityRepository->findByLogin($login);
33	1	if ($identity === null) {
34		throw new BadRequestException('No such user.');
35		}
36
37	1	if (!$identity->validatePassword($password)) {
38		throw new BadRequestException('Invalid password.');
39		}
40
41	1	if (!$this->currentUser->login($identity)) {
42		throw new BadRequestException();
43		}
44
45	1	$identity->resetToken();
46	1	$this->identityRepository->save($identity);
47	1	return $identity;
48		}
49
50	1	public function logout(User $user): void
51		{
52	1	$user->resetToken();
53	1	$this->identityRepository->save($user);
54		}
55		}
56

yiisoft / demo-api

Pull Request — master (#87)

UserService::login() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like