Test Failed
Push — master ( 09a5f1...c566a2 )
by Alexander
12:51
created

UserService   A

Complexity

Total Complexity 6

Size/Duplication

Total Lines 41
Duplicated Lines 0 %

Importance

Changes 2
Bugs 0 Features 0
Metric Value
wmc 6
eloc 17
c 2
b 0
f 0
dl 0
loc 41
rs 10

3 Methods

Rating   Name   Duplication   Size   Complexity  
A logout() 0 4 1
A login() 0 18 4
A __construct() 0 4 1
1
<?php
2
3
declare(strict_types=1);
4
5
namespace App\User;
6
7
use App\Exception\BadRequestException;
8
use Yiisoft\Auth\IdentityInterface;
9
use Yiisoft\Auth\IdentityRepositoryInterface;
10
use Yiisoft\User\User;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, App\User\User. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
11
use App\User\User as UserEntity;
12
13
final class UserService
14
{
15
    private IdentityRepositoryInterface $identityRepository;
16
    private User $user;
17
18
    public function __construct(User $user, IdentityRepositoryInterface $identityRepository)
19
    {
20
        $this->user = $user;
21
        $this->identityRepository = $identityRepository;
22
    }
23
24
    /**
25
     * @param string $login
26
     * @param string $password
27
     *
28
     * @throws BadRequestException
29
     */
30
    public function login(string $login, string $password): IdentityInterface
31
    {
32
        $identity = $this->identityRepository->findByLogin($login);
0 ignored issues
show
Bug introduced by
The method findByLogin() does not exist on Yiisoft\Auth\IdentityRepositoryInterface. It seems like you code against a sub-type of Yiisoft\Auth\IdentityRepositoryInterface such as App\User\UserRepository. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

32
        /** @scrutinizer ignore-call */ 
33
        $identity = $this->identityRepository->findByLogin($login);
Loading history...
33
        if ($identity === null) {
34
            throw new BadRequestException('No such user.');
35
        }
36
37
        if (!$identity->validatePassword($password)) {
38
            throw new BadRequestException('Invalid password.');
39
        }
40
41
        if (!$this->user->login($identity)) {
42
            throw new BadRequestException();
43
        }
44
45
        $identity->resetToken();
46
        $this->identityRepository->save($identity);
0 ignored issues
show
Bug introduced by
The method save() does not exist on Yiisoft\Auth\IdentityRepositoryInterface. It seems like you code against a sub-type of Yiisoft\Auth\IdentityRepositoryInterface such as App\User\UserRepository. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

46
        $this->identityRepository->/** @scrutinizer ignore-call */ 
47
                                   save($identity);
Loading history...
47
        return $identity;
48
    }
49
50
    public function logout(UserEntity $user): void
51
    {
52
        $user->resetToken();
53
        $this->identityRepository->save($user);
54
    }
55
}
56