BitColumn::normalizeDefaultValue() - Code Metrics - Inspection of "New columns for v2" - yiisoft/db - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#808)

by Sergei

created 2024-02-07 07:08 UTC

BitColumn::normalizeDefaultValue() A

↳ Parent: BitColumn

Complexity

Conditions	5
Paths	3

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	5
c	1
b	0
f	0
nc	3
nop	1
dl	0
loc	12
rs	9.6111

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Schema\Column;

use Yiisoft\Db\Expression\Expression;
use Yiisoft\Db\Expression\ExpressionInterface;
use Yiisoft\Db\Schema\SchemaInterface;

class BitColumn extends Column
{
    public function __construct(
        string|null $type = SchemaInterface::TYPE_BIT,
        string|null $phpType = SchemaInterface::PHP_TYPE_INTEGER,
    ) {
        parent::__construct($type, $phpType);
    }

    public function dbTypecast(mixed $value): int|string|ExpressionInterface|null
    {
        return match (true) {
            is_int($value), $value === null, $value instanceof ExpressionInterface => $value,
            $value === '' => null,
            default => (int) $value,
        };
    }

    public function phpTypecast(mixed $value): int|null
    {
        if ($value === null) {
            return null;
        }

        return (int) $value;
    }

    public function normalizeDefaultValue(string|null $value): int|ExpressionInterface|null
    {
        if ($value === null || $this->isComputed() || preg_match("/^\(?NULL\b/i", $value) === 1) {
            return null;
        }

        if (preg_match("/^[Bb]?'([01]+)'/", $value, $matches) === 1) {
            /** @var int */
            return bindec($matches[1]);

        }

        return new Expression($value);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Db\Schema\Column;
6
7			use Yiisoft\Db\Expression\Expression;
8			use Yiisoft\Db\Expression\ExpressionInterface;
9			use Yiisoft\Db\Schema\SchemaInterface;
10
11			class BitColumn extends Column
12			{
13			public function __construct(
14			string\|null $type = SchemaInterface::TYPE_BIT,
15			string\|null $phpType = SchemaInterface::PHP_TYPE_INTEGER,
16			) {
17			parent::__construct($type, $phpType);
18			}
19
20			public function dbTypecast(mixed $value): int\|string\|ExpressionInterface\|null
21			{
22			return match (true) {
23			is_int($value), $value === null, $value instanceof ExpressionInterface => $value,
24			$value === '' => null,
25			default => (int) $value,
26			};
27			}
28
29			public function phpTypecast(mixed $value): int\|null
30			{
31			if ($value === null) {
32			return null;
33			}
34
35			return (int) $value;
36			}
37
38			public function normalizeDefaultValue(string\|null $value): int\|ExpressionInterface\|null
39			{
40			if ($value === null \|\| $this->isComputed() \|\| preg_match("/^\(?NULL\b/i", $value) === 1) {
41			return null;
42			}
43
44			if (preg_match("/^[Bb]?'([01]+)'/", $value, $matches) === 1) {
45			/** @var int */
46			return bindec($matches[1]);
			0 ignored issues – show Bug Best Practice introduced 2024-02-07 07:24 UTC by Report Bug Copy Issue Report The expression `return bindec($matches[1])` could return the type `double` which is incompatible with the type-hinted return `Yiisoft\Db\Expression\Ex...nInterface\|integer\|null`. Consider adding an additional type-check to rule them out. Loading history...
47			}
48
49			return new Expression($value);
50			}
51			}
52

yiisoft / db

Pull Request — master (#808)

BitColumn::normalizeDefaultValue() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like