Connection::getSchemaCache() - Code Metrics - Inspection of "Big refactoring #2." - yiisoft/db - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#372)

by Wilmer

created 2022-10-19 12:15 UTC

Connection::getSchemaCache() A

↳ Parent: Connection

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	3
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	7
rs	10

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Tests\Support;

use Yiisoft\Cache\ArrayCache;
use Yiisoft\Cache\Cache;
use Yiisoft\Cache\CacheInterface;
use Yiisoft\Db\Cache\QueryCache;
use Yiisoft\Db\Cache\SchemaCache;

abstract class Connection
{
    private CacheInterface|null $cache = null;
    private QueryCache|null $queryCache = null;
    private SchemaCache|null $schemaCache = null;

    public function getQueryCache(): QueryCache
    {
        if ($this->queryCache === null) {
            $this->queryCache = new QueryCache($this->createCache());
        }

        return $this->queryCache;

    }

    public function getSchemaCache(): SchemaCache
    {
        if ($this->schemaCache === null) {
            $this->schemaCache = new SchemaCache($this->createCache());
        }

        return $this->schemaCache;

    }

    private function createCache(): CacheInterface
    {
        if ($this->cache === null) {
            $this->cache = new Cache(new ArrayCache());
        }

        return $this->cache;

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Db\Tests\Support;
6
7			use Yiisoft\Cache\ArrayCache;
8			use Yiisoft\Cache\Cache;
9			use Yiisoft\Cache\CacheInterface;
10			use Yiisoft\Db\Cache\QueryCache;
11			use Yiisoft\Db\Cache\SchemaCache;
12
13			abstract class Connection
14			{
15			private CacheInterface\|null $cache = null;
16			private QueryCache\|null $queryCache = null;
17			private SchemaCache\|null $schemaCache = null;
18
19			public function getQueryCache(): QueryCache
20			{
21			if ($this->queryCache === null) {
22			$this->queryCache = new QueryCache($this->createCache());
23			}
24
25			return $this->queryCache;
			0 ignored issues – show Bug Best Practice introduced 2022-02-12 12:03 UTC by Report Bug Copy Issue Report The expression `return $this->queryCache` could return the type `null` which is incompatible with the type-hinted return `Yiisoft\Db\Cache\QueryCache`. Consider adding an additional type-check to rule them out. Loading history...
26			}
27
28			public function getSchemaCache(): SchemaCache
29			{
30			if ($this->schemaCache === null) {
31			$this->schemaCache = new SchemaCache($this->createCache());
32			}
33
34			return $this->schemaCache;
			0 ignored issues – show Bug Best Practice introduced 2022-02-12 12:03 UTC by Report Bug Copy Issue Report The expression `return $this->schemaCache` could return the type `null` which is incompatible with the type-hinted return `Yiisoft\Db\Cache\SchemaCache`. Consider adding an additional type-check to rule them out. Loading history...
35			}
36
37			private function createCache(): CacheInterface
38			{
39			if ($this->cache === null) {
40			$this->cache = new Cache(new ArrayCache());
41			}
42
43			return $this->cache;
			0 ignored issues – show Bug Best Practice introduced 2022-10-19 12:08 UTC by Report Bug Copy Issue Report The expression `return $this->cache` could return the type `null` which is incompatible with the type-hinted return `Yiisoft\Cache\CacheInterface`. Consider adding an additional type-check to rule them out. Loading history...
44			}
45			}
46

yiisoft / db

Pull Request — master (#372)

Connection::getSchemaCache() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like