Mock::connection() - Code Metrics - Inspection of "Big refactoring #2." - yiisoft/db - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#372)

by Wilmer

created 2022-10-19 12:50 UTC

Mock::connection() A

↳ Parent: Mock

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	3
rs	10

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Tests\Support;

use PHPUnit\Framework\TestCase;
use Yiisoft\Cache\ArrayCache;
use Yiisoft\Cache\Cache;
use Yiisoft\Cache\CacheInterface;
use Yiisoft\Db\Cache\SchemaCache;
use Yiisoft\Db\Connection\ConnectionInterface;
use Yiisoft\Db\Query\Helper\QueryHelper;

final class Mock extends TestCase
{
    private CacheInterface|null $cache = null;
    private SchemaCache|null $schemaCache = null;

    public function cache(): CacheInterface
    {
        if ($this->cache === null) {
            $this->cache = new Cache(new ArrayCache());
        }

        return $this->cache;

    }

    public function connection(): ConnectionInterface
    {
        return $this->createMock(ConnectionInterface::class);

    }

    public static function queryHelper(): QueryHelper
    {
        return new QueryHelper();
    }

    public function schemaCache(): SchemaCache
    {
        if ($this->schemaCache === null) {
            $this->schemaCache = new SchemaCache($this->cache());
        }

        return $this->schemaCache;

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Db\Tests\Support;
6
7			use PHPUnit\Framework\TestCase;
8			use Yiisoft\Cache\ArrayCache;
9			use Yiisoft\Cache\Cache;
10			use Yiisoft\Cache\CacheInterface;
11			use Yiisoft\Db\Cache\SchemaCache;
12			use Yiisoft\Db\Connection\ConnectionInterface;
13			use Yiisoft\Db\Query\Helper\QueryHelper;
14
15			final class Mock extends TestCase
16			{
17			private CacheInterface\|null $cache = null;
18			private SchemaCache\|null $schemaCache = null;
19
20			public function cache(): CacheInterface
21			{
22			if ($this->cache === null) {
23			$this->cache = new Cache(new ArrayCache());
24			}
25
26			return $this->cache;
			0 ignored issues – show Bug Best Practice introduced 2022-06-19 16:29 UTC by Report Bug Copy Issue Report The expression `return $this->cache` could return the type `null` which is incompatible with the type-hinted return `Yiisoft\Cache\CacheInterface`. Consider adding an additional type-check to rule them out. Loading history...
27			}
28
29			public function connection(): ConnectionInterface
30			{
31			return $this->createMock(ConnectionInterface::class);
			0 ignored issues – show Bug Best Practice introduced 2022-10-19 12:08 UTC by Report Bug Copy Issue Report The expression `return $this->createMock...ectionInterface::class)` returns the type `PHPUnit\Framework\MockObject\MockObject` which is incompatible with the type-hinted return `Yiisoft\Db\Connection\ConnectionInterface`. Loading history...
32			}
33
34			public static function queryHelper(): QueryHelper
35			{
36			return new QueryHelper();
37			}
38
39			public function schemaCache(): SchemaCache
40			{
41			if ($this->schemaCache === null) {
42			$this->schemaCache = new SchemaCache($this->cache());
43			}
44
45			return $this->schemaCache;
			0 ignored issues – show Bug Best Practice introduced 2021-10-01 13:46 UTC by Report Bug Copy Issue Report The expression `return $this->schemaCache` could return the type `null` which is incompatible with the type-hinted return `Yiisoft\Db\Cache\SchemaCache`. Consider adding an additional type-check to rule them out. Loading history...
46			}
47			}
48

yiisoft / db

Pull Request — master (#372)

Mock::connection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like