BetweenColumnsCondition::fromArrayDefinition() - Code Metrics - Inspection of "Rework tests" - yiisoft/db - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#376)

by Wilmer

created 2022-11-01 00:14 UTC

BetweenColumnsCondition::fromArrayDefinition() B

↳ Parent: BetweenColumnsCondition

Complexity

Conditions	11
Paths	5

Size

Total Lines	37
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	11
eloc	21
c	1
b	0
f	0
nc	5
nop	2
dl	0
loc	37
rs	7.3166

How to fix Complexity

<?php

declare(strict_types=1);

namespace Yiisoft\Db\QueryBuilder\Conditions;

use Iterator;
use Yiisoft\Db\Exception\InvalidArgumentException;
use Yiisoft\Db\Expression\ExpressionInterface;
use Yiisoft\Db\QueryBuilder\Conditions\Interface\BetweenColumnsConditionInterface;

/**
 * Class BetweenColumnCondition represents a `BETWEEN` condition where values are between two columns.
 *
 * For example:.
 *
 * ```php
 * new BetweenColumnsCondition(42, 'BETWEEN', 'min_value', 'max_value')
 * // Will be build to:
 * // 42 BETWEEN min_value AND max_value
 * ```
 *
 * And a more complex example:
 *
 * ```php
 * new BetweenColumnsCondition(
 *    new Expression('NOW()'),
 *    'NOT BETWEEN',
 *    (new Query)->select('time')->from('log')->orderBy('id ASC')->limit(1),
 *    'update_time'
 * );
 *
 * // Will be built to:
 * // NOW() NOT BETWEEN (SELECT time FROM log ORDER BY id ASC LIMIT 1) AND update_time
 * ```
 */
final class BetweenColumnsCondition implements BetweenColumnsConditionInterface
{
    public function __construct(
        private array|int|string|Iterator|ExpressionInterface $value,
        private string $operator,
        private string|ExpressionInterface $intervalStartColumn,
        private string|ExpressionInterface $intervalEndColumn
    ) {
    }

    public function getIntervalEndColumn(): string|ExpressionInterface
    {
        return $this->intervalEndColumn;
    }

    public function getIntervalStartColumn(): string|ExpressionInterface
    {
        return $this->intervalStartColumn;
    }

    public function getOperator(): string
    {
        return $this->operator;
    }

    public function getValue(): array|int|string|Iterator|ExpressionInterface
    {
        return $this->value;
    }

    /**
     * @throws InvalidArgumentException
     */
    public static function fromArrayDefinition(string $operator, array $operands): self
    {
        if (!isset($operands[0], $operands[1], $operands[2])) {
            throw new InvalidArgumentException("Operator '$operator' requires three operands.");
        }

        if (
            !is_array($operands[0]) &&
            !is_int($operands[0]) &&
            !is_string($operands[0]) &&
            !($operands[0] instanceof Iterator) &&
            !($operands[0] instanceof ExpressionInterface)
        ) {
            throw new InvalidArgumentException(
                "Operator '$operator' requires value to be array, int, string, Iterator or ExpressionInterface."
            );
        }

        if (
            !is_string($operands[1]) &&
            !($operands[1] instanceof ExpressionInterface)
        ) {
            throw new InvalidArgumentException(
                "Operator '$operator' requires interval start column to be string or ExpressionInterface."
            );
        }

        if (
            !is_string($operands[2]) &&
            !($operands[2] instanceof ExpressionInterface)
        ) {
            throw new InvalidArgumentException(
                "Operator '$operator' requires interval end column to be string or ExpressionInterface."
            );
        }

        return new self($operands[0], $operator, $operands[1], $operands[2]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Db\QueryBuilder\Conditions;
6
7			use Iterator;
8			use Yiisoft\Db\Exception\InvalidArgumentException;
9			use Yiisoft\Db\Expression\ExpressionInterface;
10			use Yiisoft\Db\QueryBuilder\Conditions\Interface\BetweenColumnsConditionInterface;
11
12			/**
13			* Class BetweenColumnCondition represents a `BETWEEN` condition where values are between two columns.
14			*
15			* For example:.
16			*
17			* ```php
18			* new BetweenColumnsCondition(42, 'BETWEEN', 'min_value', 'max_value')
19			* // Will be build to:
20			* // 42 BETWEEN min_value AND max_value
21			* ```
22			*
23			* And a more complex example:
24			*
25			* ```php
26			* new BetweenColumnsCondition(
27			* new Expression('NOW()'),
28			* 'NOT BETWEEN',
29			* (new Query)->select('time')->from('log')->orderBy('id ASC')->limit(1),
30			* 'update_time'
31			* );
32			*
33			* // Will be built to:
34			* // NOW() NOT BETWEEN (SELECT time FROM log ORDER BY id ASC LIMIT 1) AND update_time
35			* ```
36			*/
37			final class BetweenColumnsCondition implements BetweenColumnsConditionInterface
38			{
39			public function __construct(
40			private array\|int\|string\|Iterator\|ExpressionInterface $value,
41			private string $operator,
42			private string\|ExpressionInterface $intervalStartColumn,
43			private string\|ExpressionInterface $intervalEndColumn
44			) {
45			}
46
47			public function getIntervalEndColumn(): string\|ExpressionInterface
48			{
49			return $this->intervalEndColumn;
50			}
51
52			public function getIntervalStartColumn(): string\|ExpressionInterface
53			{
54			return $this->intervalStartColumn;
55			}
56
57			public function getOperator(): string
58			{
59			return $this->operator;
60			}
61
62			public function getValue(): array\|int\|string\|Iterator\|ExpressionInterface
63			{
64			return $this->value;
65			}
66
67			/**
68			* @throws InvalidArgumentException
69			*/
70			public static function fromArrayDefinition(string $operator, array $operands): self
71			{
72			if (!isset($operands[0], $operands[1], $operands[2])) {
73			throw new InvalidArgumentException("Operator '$operator' requires three operands.");
74			}
75
76			if (
77			!is_array($operands[0]) &&
78			!is_int($operands[0]) &&
79			!is_string($operands[0]) &&
80			!($operands[0] instanceof Iterator) &&
81			!($operands[0] instanceof ExpressionInterface)
82			) {
83			throw new InvalidArgumentException(
84			"Operator '$operator' requires value to be array, int, string, Iterator or ExpressionInterface."
85			);
86			}
87
88			if (
89			!is_string($operands[1]) &&
90			!($operands[1] instanceof ExpressionInterface)
91			) {
92			throw new InvalidArgumentException(
93			"Operator '$operator' requires interval start column to be string or ExpressionInterface."
94			);
95			}
96
97			if (
98			!is_string($operands[2]) &&
99			!($operands[2] instanceof ExpressionInterface)
100			) {
101			throw new InvalidArgumentException(
102			"Operator '$operator' requires interval end column to be string or ExpressionInterface."
103			);
104			}
105
106			return new self($operands[0], $operator, $operands[1], $operands[2]);
107			}
108			}
109

yiisoft / db

Pull Request — master (#376)

BetweenColumnsCondition::fromArrayDefinition() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like