QueryHelper::filterCondition() - Code Metrics - Inspection of "Query helper" - yiisoft/db - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#511)

by Def

created 2023-02-12 17:07 UTC

QueryHelper::filterCondition() D

↳ Parent: QueryHelper

Complexity

Conditions	19
Paths	18

Size

Total Lines	61
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	34
dl	0
loc	61
rs	4.5166
c	0
b	0
f	0
cc	19
nc	18
nop	1

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Query\Helper;

use Yiisoft\Db\Expression\ExpressionInterface;

use function array_key_exists;
use function array_shift;
use function array_unshift;
use function is_string;
use function preg_match;
use function preg_split;
use function str_contains;
use function strcasecmp;
use function strtoupper;
use function trim;

/**
 * The QueryHelper provides a set of helper methods for working with database queries. These methods can be used to
 * simplify the process of building and executing complex database queries.
 */
final class QueryHelper
{
    /**
     * Removes {@see isEmpty()|empty operands} from the given query condition.
     *
     * @param array|string $condition the original condition
     *
     * @return array|string the condition with {@see isEmpty()|empty operands} removed.
     */
    public function filterCondition(array|string $condition): array|string
    {
        if (!is_array($condition)) {

            return $condition;
        }

        if (!isset($condition[0])) {
            /** hash format: 'column1' => 'value1', 'column2' => 'value2', ... */
            /** @var mixed $value */
            foreach ($condition as $name => $value) {
                if ($this->isEmpty($value)) {
                    unset($condition[$name]);
                }
            }

            return $condition;
        }

        /** operator format: operator, operand 1, operand 2, ... */
        /** @var string */
        $operator = array_shift($condition);

        switch (strtoupper($operator)) {
            case 'NOT':
            case 'AND':
            case 'OR':
                /** @psalm-var array<array-key, array|string> $condition */
                foreach ($condition as $i => $operand) {
                    $subCondition = $this->filterCondition($operand);
                    if ($this->isEmpty($subCondition)) {
                        unset($condition[$i]);
                    } else {
                        $condition[$i] = $subCondition;
                    }
                }

                if (empty($condition)) {
                    return [];
                }

                break;
            case 'BETWEEN':
            case 'NOT BETWEEN':
                if (array_key_exists(1, $condition) && array_key_exists(2, $condition)) {
                    if ($this->isEmpty($condition[1]) || $this->isEmpty($condition[2])) {
                        return [];
                    }
                } else {
                    return [];
                }

                break;
            default:
                if (array_key_exists(1, $condition) && $this->isEmpty($condition[1])) {
                    return [];
                }
        }

        array_unshift($condition, $operator);

        return $condition;
    }

    /**
     * Returns a value indicating whether the give value is "empty".
     *
     * The value is considered "empty", if one of the following conditions is satisfied:
     *
     * - it is `null`,
     * - an empty string (`''`),
     * - a string containing only whitespace characters,
     * - or an empty array.
     *
     * @param mixed $value
     *
     * @return bool if the value is empty
     */
    public function isEmpty(mixed $value): bool
    {
        return $value === '' || $value === [] || $value === null || (is_string($value) && trim($value) === '');
    }

    /**
     * Normalizes format of ORDER BY data.
     *
     * @param array|ExpressionInterface|string $columns the columns value to normalize.
     *
     * See {@see orderBy} and {@see addOrderBy}.
     */
    public function normalizeOrderBy(array|string|ExpressionInterface $columns): array
    {
        if ($columns instanceof ExpressionInterface) {

            return [$columns];
        }

        if (is_array($columns)) {

            return $columns;
        }

        $columns = preg_split('/\s*,\s*/', trim($columns), -1, PREG_SPLIT_NO_EMPTY);
        $result = [];

        foreach ($columns as $column) {
            if (preg_match('/^(.*?)\s+(asc|desc)$/i', $column, $matches)) {
                $result[$matches[1]] = strcasecmp($matches[2], 'desc') ? SORT_ASC : SORT_DESC;
            } else {
                $result[$column] = SORT_ASC;
            }
        }

        return $result;
    }

    /**
     * Normalizes the SELECT columns passed to {@see select()} or {@see addSelect()}.
     */
    public function normalizeSelect(array|ExpressionInterface|string $columns): array
    {
        if ($columns instanceof ExpressionInterface) {

            $columns = [$columns];
        } elseif (!is_array($columns)) {

            $columns = preg_split('/\s*,\s*/', trim($columns), -1, PREG_SPLIT_NO_EMPTY);
        }

        $select = [];

        /** @psalm-var array<array-key, ExpressionInterface|string> $columns */
        foreach ($columns as $columnAlias => $columnDefinition) {
            if (is_string($columnAlias)) {
                // Already in the normalized format, good for them.
                $select[$columnAlias] = $columnDefinition;
                continue;
            }

            if (is_string($columnDefinition)) {
                if (
                    preg_match('/^(.*?)(?i:\s+as\s+|\s+)([\w\-_.]+)$/', $columnDefinition, $matches) &&
                    !preg_match('/^\d+$/', $matches[2]) &&
                    !str_contains($matches[2], '.')
                ) {
                    /** Using "columnName as alias" or "columnName alias" syntax */
                    $select[$matches[2]] = $matches[1];
                    continue;
                }
                if (!str_contains($columnDefinition, '(')) {
                    /** Normal column name, just alias it to itself to ensure it's not selected twice */
                    $select[$columnDefinition] = $columnDefinition;
                    continue;
                }
            }

            // Either a string calling a function, DB expression, or sub-query
            /** @var string */
            $select[] = $columnDefinition;
        }

        return $select;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Db\Query\Helper;
6
7			use Yiisoft\Db\Expression\ExpressionInterface;
8
9			use function array_key_exists;
10			use function array_shift;
11			use function array_unshift;
12			use function is_string;
13			use function preg_match;
14			use function preg_split;
15			use function str_contains;
16			use function strcasecmp;
17			use function strtoupper;
18			use function trim;
19
20			/**
21			* The QueryHelper provides a set of helper methods for working with database queries. These methods can be used to
22			* simplify the process of building and executing complex database queries.
23			*/
24			final class QueryHelper
25			{
26			/**
27			* Removes {@see isEmpty()\|empty operands} from the given query condition.
28			*
29			* @param array\|string $condition the original condition
30			*
31			* @return array\|string the condition with {@see isEmpty()\|empty operands} removed.
32			*/
33			public function filterCondition(array\|string $condition): array\|string
34			{
35			if (!is_array($condition)) {
			0 ignored issues – show introduced 2022-04-14 20:05 UTC by Report Bug Copy Issue Report The condition `is_array($condition)` is always `true`. Loading history...
36			return $condition;
37			}
38
39			if (!isset($condition[0])) {
40			/** hash format: 'column1' => 'value1', 'column2' => 'value2', ... */
41			/** @var mixed $value */
42			foreach ($condition as $name => $value) {
43			if ($this->isEmpty($value)) {
44			unset($condition[$name]);
45			}
46			}
47
48			return $condition;
49			}
50
51			/** operator format: operator, operand 1, operand 2, ... */
52			/** @var string */
53			$operator = array_shift($condition);
54
55			switch (strtoupper($operator)) {
56			case 'NOT':
57			case 'AND':
58			case 'OR':
59			/** @psalm-var array<array-key, array\|string> $condition */
60			foreach ($condition as $i => $operand) {
61			$subCondition = $this->filterCondition($operand);
62			if ($this->isEmpty($subCondition)) {
63			unset($condition[$i]);
64			} else {
65			$condition[$i] = $subCondition;
66			}
67			}
68
69			if (empty($condition)) {
70			return [];
71			}
72
73			break;
74			case 'BETWEEN':
75			case 'NOT BETWEEN':
76			if (array_key_exists(1, $condition) && array_key_exists(2, $condition)) {
77			if ($this->isEmpty($condition[1]) \|\| $this->isEmpty($condition[2])) {
78			return [];
79			}
80			} else {
81			return [];
82			}
83
84			break;
85			default:
86			if (array_key_exists(1, $condition) && $this->isEmpty($condition[1])) {
87			return [];
88			}
89			}
90
91			array_unshift($condition, $operator);
92
93			return $condition;
94			}
95
96			/**
97			* Returns a value indicating whether the give value is "empty".
98			*
99			* The value is considered "empty", if one of the following conditions is satisfied:
100			*
101			* - it is `null`,
102			* - an empty string (`''`),
103			* - a string containing only whitespace characters,
104			* - or an empty array.
105			*
106			* @param mixed $value
107			*
108			* @return bool if the value is empty
109			*/
110			public function isEmpty(mixed $value): bool
111			{
112			return $value === '' \|\| $value === [] \|\| $value === null \|\| (is_string($value) && trim($value) === '');
113			}
114
115			/**
116			* Normalizes format of ORDER BY data.
117			*
118			* @param array\|ExpressionInterface\|string $columns the columns value to normalize.
119			*
120			* See {@see orderBy} and {@see addOrderBy}.
121			*/
122			public function normalizeOrderBy(array\|string\|ExpressionInterface $columns): array
123			{
124			if ($columns instanceof ExpressionInterface) {
			0 ignored issues – show introduced 2022-04-14 20:05 UTC by Report Bug Copy Issue Report `$columns` is never a sub-type of `Yiisoft\Db\Expression\ExpressionInterface`. Loading history...
125			return [$columns];
126			}
127
128			if (is_array($columns)) {
			0 ignored issues – show introduced 2022-04-14 20:05 UTC by Report Bug Copy Issue Report The condition `is_array($columns)` is always `true`. Loading history...
129			return $columns;
130			}
131
132			$columns = preg_split('/\s,\s/', trim($columns), -1, PREG_SPLIT_NO_EMPTY);
133			$result = [];
134
135			foreach ($columns as $column) {
136			if (preg_match('/^(.*?)\s+(asc\|desc)$/i', $column, $matches)) {
137			$result[$matches[1]] = strcasecmp($matches[2], 'desc') ? SORT_ASC : SORT_DESC;
138			} else {
139			$result[$column] = SORT_ASC;
140			}
141			}
142
143			return $result;
144			}
145
146			/**
147			* Normalizes the SELECT columns passed to {@see select()} or {@see addSelect()}.
148			*/
149			public function normalizeSelect(array\|ExpressionInterface\|string $columns): array
150			{
151			if ($columns instanceof ExpressionInterface) {
			0 ignored issues – show introduced 2022-04-14 20:05 UTC by Report Bug Copy Issue Report `$columns` is never a sub-type of `Yiisoft\Db\Expression\ExpressionInterface`. Loading history...
152			$columns = [$columns];
153			} elseif (!is_array($columns)) {
			0 ignored issues – show introduced 2022-04-14 20:05 UTC by Report Bug Copy Issue Report The condition `is_array($columns)` is always `true`. Loading history...
154			$columns = preg_split('/\s,\s/', trim($columns), -1, PREG_SPLIT_NO_EMPTY);
155			}
156
157			$select = [];
158
159			/** @psalm-var array<array-key, ExpressionInterface\|string> $columns */
160			foreach ($columns as $columnAlias => $columnDefinition) {
161			if (is_string($columnAlias)) {
162			// Already in the normalized format, good for them.
163			$select[$columnAlias] = $columnDefinition;
164			continue;
165			}
166
167			if (is_string($columnDefinition)) {
168			if (
169			preg_match('/^(.*?)(?i:\s+as\s+\|\s+)([\w\-_.]+)$/', $columnDefinition, $matches) &&
170			!preg_match('/^\d+$/', $matches[2]) &&
171			!str_contains($matches[2], '.')
172			) {
173			/** Using "columnName as alias" or "columnName alias" syntax */
174			$select[$matches[2]] = $matches[1];
175			continue;
176			}
177			if (!str_contains($columnDefinition, '(')) {
178			/** Normal column name, just alias it to itself to ensure it's not selected twice */
179			$select[$columnDefinition] = $columnDefinition;
180			continue;
181			}
182			}
183
184			// Either a string calling a function, DB expression, or sub-query
185			/** @var string */
186			$select[] = $columnDefinition;
187			}
188
189			return $select;
190			}
191			}
192

yiisoft / db

Pull Request — master (#511)

QueryHelper::filterCondition() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like