BitColumn::normalizeDefaultValue() - Code Metrics - Inspection of "New columns for v2" - yiisoft/db - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#808)

by Sergei

created 2024-04-22 08:27 UTC

BitColumn::normalizeDefaultValue() A

↳ Parent: BitColumn

Complexity

Conditions	5
Paths	3

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	5
eloc	5
c	2
b	0
f	0
nc	3
nop	1
dl	0
loc	12
rs	9.6111

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Schema\Column;

use Yiisoft\Db\Expression\Expression;
use Yiisoft\Db\Expression\ExpressionInterface;
use Yiisoft\Db\Schema\SchemaInterface;

use function bindec;
use function preg_match;

class BitColumn extends Column
{
    public function __construct(
        string|null $type = SchemaInterface::TYPE_BIT,

        string|null $phpType = SchemaInterface::PHP_TYPE_INTEGER,
    ) {
        parent::__construct($type, $phpType);
    }

    public function dbTypecast(mixed $value): int|string|ExpressionInterface|null
    {
        if ($value instanceof ExpressionInterface) {
            return $value;
        }

        return match ($value) {
            null, '' => null,
            default => (int) $value,
        };
    }

    public function phpTypecast(mixed $value): int|null
    {
        if ($value === null) {
            return null;
        }

        return (int) $value;
    }

    public function normalizeDefaultValue(string|null $value): int|ExpressionInterface|null
    {
        if ($value === null || $this->isComputed() || preg_match("/^\(?NULL\b/i", $value) === 1) {
            return null;
        }

        if (preg_match("/^[Bb]?'([01]+)'/", $value, $matches) === 1) {
            /** @var int */
            return bindec($matches[1]);

        }

        return new Expression($value);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Db\Schema\Column;
6
7			use Yiisoft\Db\Expression\Expression;
8			use Yiisoft\Db\Expression\ExpressionInterface;
9			use Yiisoft\Db\Schema\SchemaInterface;
10
11			use function bindec;
12			use function preg_match;
13
14			class BitColumn extends Column
15			{
16			public function __construct(
17			string\|null $type = SchemaInterface::TYPE_BIT,
			0 ignored issues – show Bug introduced 2024-04-22 08:29 UTC by Report Bug Copy Issue Report The constant `Yiisoft\Db\Schema\SchemaInterface::TYPE_BIT` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
18			string\|null $phpType = SchemaInterface::PHP_TYPE_INTEGER,
19			) {
20			parent::__construct($type, $phpType);
21			}
22
23			public function dbTypecast(mixed $value): int\|string\|ExpressionInterface\|null
24			{
25			if ($value instanceof ExpressionInterface) {
26			return $value;
27			}
28
29			return match ($value) {
30			null, '' => null,
31			default => (int) $value,
32			};
33			}
34
35			public function phpTypecast(mixed $value): int\|null
36			{
37			if ($value === null) {
38			return null;
39			}
40
41			return (int) $value;
42			}
43
44			public function normalizeDefaultValue(string\|null $value): int\|ExpressionInterface\|null
45			{
46			if ($value === null \|\| $this->isComputed() \|\| preg_match("/^\(?NULL\b/i", $value) === 1) {
47			return null;
48			}
49
50			if (preg_match("/^[Bb]?'([01]+)'/", $value, $matches) === 1) {
51			/** @var int */
52			return bindec($matches[1]);
			0 ignored issues – show Bug Best Practice introduced 2024-02-07 07:24 UTC by Report Bug Copy Issue Report The expression `return bindec($matches[1])` could return the type `double` which is incompatible with the type-hinted return `Yiisoft\Db\Expression\Ex...nInterface\|integer\|null`. Consider adding an additional type-check to rule them out. Loading history...
53			}
54
55			return new Expression($value);
56			}
57			}
58

yiisoft / db

Pull Request — master (#808)

BitColumn::normalizeDefaultValue() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like