DQLQueryBuilder::build() - Code Metrics - Inspection of "QueryBuilder refactoring" - yiisoft/db-sqlite - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — dev (#103)

by Def

created 2022-05-03 20:21 UTC

DQLQueryBuilder::build() B

↳ Parent: DQLQueryBuilder

Complexity

Conditions	10
Paths	32

Size

Total Lines	52
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	28
c	1
b	0
f	0
dl	0
loc	52
rs	7.6666
cc	10
nc	32
nop	2

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Sqlite;

use Yiisoft\Db\Expression\Expression;
use Yiisoft\Db\Expression\ExpressionBuilderInterface;
use Yiisoft\Db\Expression\ExpressionInterface;
use Yiisoft\Db\Query\Conditions\InCondition;
filter:
    dependency_paths: ["lib/*"]
use Yiisoft\Db\Query\Conditions\LikeCondition;
filter:
    dependency_paths: ["lib/*"]
use Yiisoft\Db\Query\DQLQueryBuilder as AbstractDQLQueryBuilder;
filter:
    dependency_paths: ["lib/*"]
use Yiisoft\Db\Query\Query;
use Yiisoft\Db\Query\QueryInterface;
use Yiisoft\Db\Sqlite\Builder\InConditionBuilder;
use Yiisoft\Db\Sqlite\Builder\LikeConditionBuilder;

use function array_filter;
use function array_merge;
use function implode;
use function trim;

final class DQLQueryBuilder extends AbstractDQLQueryBuilder
{
    public function build(QueryInterface $query, array $params = []): array
    {
        $query = $query->prepare($this->queryBuilder);

        $params = empty($params) ? $query->getParams() : array_merge($params, $query->getParams());

        $clauses = [
            $this->buildSelect($query->getSelect(), $params, $query->getDistinct(), $query->getSelectOption()),
            $this->buildFrom($query->getFrom(), $params),
            $this->buildJoin($query->getJoin(), $params),
            $this->buildWhere($query->getWhere(), $params),
            $this->buildGroupBy($query->getGroupBy()),
            $this->buildHaving($query->getHaving(), $params),
        ];

        $orderBy = $query->getOrderBy();
        $sql = implode($this->separator, array_filter($clauses));
        $sql = $this->buildOrderByAndLimit($sql, $orderBy, $query->getLimit(), $query->getOffset());

        if (!empty($orderBy)) {
            /** @psalm-var array<string|ExpressionInterface> $orderBy */
            foreach ($orderBy as $expression) {
                if ($expression instanceof ExpressionInterface) {
                    $this->buildExpression($expression, $params);
                }
            }
        }

        $groupBy = $query->getGroupBy();

        if (!empty($groupBy)) {
            /** @psalm-var array<string|ExpressionInterface> $groupBy */
            foreach ($groupBy as $expression) {
                if ($expression instanceof ExpressionInterface) {
                    $this->buildExpression($expression, $params);
                }
            }
        }

        $union = $this->buildUnion($query->getUnion(), $params);

        if ($union !== '') {
            $sql = "$sql$this->separator$union";
        }

        $with = $this->buildWithQueries($query->getWithQueries(), $params);

        if ($with !== '') {
            $sql = "$with$this->separator$sql";
        }

        return [$sql, $params];
    }

    public function buildLimit(Expression|int|null $limit, Expression|int|null $offset): string
    {
        $sql = '';

        if ($this->hasLimit($limit)) {
            $sql = "LIMIT $limit";
            if ($this->hasOffset($offset)) {
                $sql .= " OFFSET $offset";
            }
        } elseif ($this->hasOffset($offset)) {
            /**
             * limit is not optional in SQLite.
             *
             * {@see http://www.sqlite.org/syntaxdiagrams.html#select-stmt}
             */
            $sql = "LIMIT 9223372036854775807 OFFSET $offset"; // 2^63-1
        }

        return $sql;
    }

    public function buildUnion(array $unions, array &$params = []): string
    {
        if (empty($unions)) {
            return '';
        }

        $result = '';

        /** @psalm-var array<array-key, array{query: Query|null, all: bool}> $unions */
        foreach ($unions as $i => $union) {
            $query = $union['query'];
            if ($query instanceof Query) {
                [$unions[$i]['query'], $params] = $this->build($query, $params);
            }

            $result .= ' UNION ' . ($union['all'] ? 'ALL ' : '') . ' ' . (string) $unions[$i]['query'];
        }

        return trim($result);
    }

    /**
     * Contains array of default expression builders. Extend this method and override it, if you want to change default
     * expression builders for this query builder.
     *
     * @return array
     *
     * See {@see ExpressionBuilder} docs for details.
     *
     * @psalm-return array<string, class-string<ExpressionBuilderInterface>>
     */
    protected function defaultExpressionBuilders(): array
    {
        return array_merge(parent::defaultExpressionBuilders(), [
            LikeCondition::class => LikeConditionBuilder::class,
            InCondition::class => InConditionBuilder::class,
        ]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Db\Sqlite;
6
7			use Yiisoft\Db\Expression\Expression;
8			use Yiisoft\Db\Expression\ExpressionBuilderInterface;
9			use Yiisoft\Db\Expression\ExpressionInterface;
10			use Yiisoft\Db\Query\Conditions\InCondition;
			0 ignored issues – show Bug introduced 2022-02-22 20:54 UTC by Report Bug Copy Issue Report The type `Yiisoft\Db\Query\Conditions\InCondition` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use Yiisoft\Db\Query\Conditions\LikeCondition;
			0 ignored issues – show Bug introduced 2022-02-22 20:54 UTC by Report Bug Copy Issue Report The type `Yiisoft\Db\Query\Conditions\LikeCondition` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
12			use Yiisoft\Db\Query\DQLQueryBuilder as AbstractDQLQueryBuilder;
			0 ignored issues – show Bug introduced 2022-05-03 20:35 UTC by Report Bug Copy Issue Report The type `Yiisoft\Db\Query\DQLQueryBuilder` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
13			use Yiisoft\Db\Query\Query;
14			use Yiisoft\Db\Query\QueryInterface;
15			use Yiisoft\Db\Sqlite\Builder\InConditionBuilder;
16			use Yiisoft\Db\Sqlite\Builder\LikeConditionBuilder;
17
18			use function array_filter;
19			use function array_merge;
20			use function implode;
21			use function trim;
22
23			final class DQLQueryBuilder extends AbstractDQLQueryBuilder
24			{
25			public function build(QueryInterface $query, array $params = []): array
26			{
27			$query = $query->prepare($this->queryBuilder);
28
29			$params = empty($params) ? $query->getParams() : array_merge($params, $query->getParams());
30
31			$clauses = [
32			$this->buildSelect($query->getSelect(), $params, $query->getDistinct(), $query->getSelectOption()),
33			$this->buildFrom($query->getFrom(), $params),
34			$this->buildJoin($query->getJoin(), $params),
35			$this->buildWhere($query->getWhere(), $params),
36			$this->buildGroupBy($query->getGroupBy()),
37			$this->buildHaving($query->getHaving(), $params),
38			];
39
40			$orderBy = $query->getOrderBy();
41			$sql = implode($this->separator, array_filter($clauses));
42			$sql = $this->buildOrderByAndLimit($sql, $orderBy, $query->getLimit(), $query->getOffset());
43
44			if (!empty($orderBy)) {
45			/** @psalm-var array<string\|ExpressionInterface> $orderBy */
46			foreach ($orderBy as $expression) {
47			if ($expression instanceof ExpressionInterface) {
48			$this->buildExpression($expression, $params);
49			}
50			}
51			}
52
53			$groupBy = $query->getGroupBy();
54
55			if (!empty($groupBy)) {
56			/** @psalm-var array<string\|ExpressionInterface> $groupBy */
57			foreach ($groupBy as $expression) {
58			if ($expression instanceof ExpressionInterface) {
59			$this->buildExpression($expression, $params);
60			}
61			}
62			}
63
64			$union = $this->buildUnion($query->getUnion(), $params);
65
66			if ($union !== '') {
67			$sql = "$sql$this->separator$union";
68			}
69
70			$with = $this->buildWithQueries($query->getWithQueries(), $params);
71
72			if ($with !== '') {
73			$sql = "$with$this->separator$sql";
74			}
75
76			return [$sql, $params];
77			}
78
79			public function buildLimit(Expression\|int\|null $limit, Expression\|int\|null $offset): string
80			{
81			$sql = '';
82
83			if ($this->hasLimit($limit)) {
84			$sql = "LIMIT $limit";
85			if ($this->hasOffset($offset)) {
86			$sql .= " OFFSET $offset";
87			}
88			} elseif ($this->hasOffset($offset)) {
89			/**
90			* limit is not optional in SQLite.
91			*
92			* {@see http://www.sqlite.org/syntaxdiagrams.html#select-stmt}
93			*/
94			$sql = "LIMIT 9223372036854775807 OFFSET $offset"; // 2^63-1
95			}
96
97			return $sql;
98			}
99
100			public function buildUnion(array $unions, array &$params = []): string
101			{
102			if (empty($unions)) {
103			return '';
104			}
105
106			$result = '';
107
108			/** @psalm-var array<array-key, array{query: Query\|null, all: bool}> $unions */
109			foreach ($unions as $i => $union) {
110			$query = $union['query'];
111			if ($query instanceof Query) {
112			[$unions[$i]['query'], $params] = $this->build($query, $params);
113			}
114
115			$result .= ' UNION ' . ($union['all'] ? 'ALL ' : '') . ' ' . (string) $unions[$i]['query'];
116			}
117
118			return trim($result);
119			}
120
121			/**
122			* Contains array of default expression builders. Extend this method and override it, if you want to change default
123			* expression builders for this query builder.
124			*
125			* @return array
126			*
127			* See {@see ExpressionBuilder} docs for details.
128			*
129			* @psalm-return array<string, class-string<ExpressionBuilderInterface>>
130			*/
131			protected function defaultExpressionBuilders(): array
132			{
133			return array_merge(parent::defaultExpressionBuilders(), [
134			LikeCondition::class => LikeConditionBuilder::class,
135			InCondition::class => InConditionBuilder::class,
136			]);
137			}
138			}
139

yiisoft / db-sqlite

Pull Request — dev (#103)

DQLQueryBuilder::build() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like