ArrayParser::parseUnquotedString() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master' into..." - yiisoft/db-pgsql - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dependabot/composer/rector/rec... ( 76b5ef...614a52 )

by Sergei

created 2023-07-24 10:31 UTC

ArrayParser::parseUnquotedString() A

↳ Parent: ArrayParser

Complexity

Conditions	4
Paths	4

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	6
nc	4
nop	2
dl	0
loc	10
ccs	7
cts	7
cp	1
crap	4
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Pgsql;

use function in_array;

/**
 * Array representation to PHP array parser for PostgreSQL Server.
 */
final class ArrayParser
{
    /**
     * Convert an array from PostgresSQL to PHP.
     *
     * @param string|null $value String to convert.
     */
    public function parse(string|null $value): array|null
    {
        return $value !== null && $value[0] === '{'
            ? $this->parseArray($value)
            : null;
    }

    /**
     * Parse PostgreSQL array encoded in string.
     *
     * @param string $value String to parse.
     * @param int $i parse starting position.
     */
    private function parseArray(string $value, int &$i = 0): array
    {
        if ($value[++$i] === '}') {
            ++$i;
            return [];
        }

        for ($result = [];; ++$i) {
            $result[] = match ($value[$i]) {
                '{' => $this->parseArray($value, $i),
                ',', '}' => null,
                '"' => $this->parseQuotedString($value, $i),
                default => $this->parseUnquotedString($value, $i),
            };

            if ($value[$i] === '}') {
                ++$i;
                return $result;
            }
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }

    /**
     * Parses quoted string.
     */
    private function parseQuotedString(string $value, int &$i): string
    {
        for ($result = '', ++$i;; ++$i) {
            if ($value[$i] === '\\') {
                ++$i;
            } elseif ($value[$i] === '"') {
                ++$i;
                return $result;
            }

            $result .= $value[$i];
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }

    /**
     * Parses unquoted string.
     */
    private function parseUnquotedString(string $value, int &$i): string|null
    {
        for ($result = '';; ++$i) {
            if (in_array($value[$i], [',', '}'], true)) {
                return $result !== 'NULL'
                    ? $result
                    : null;
            }

            $result .= $value[$i];
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Db\Pgsql;
6
7		use function in_array;
8
9		/**
10		* Array representation to PHP array parser for PostgreSQL Server.
11		*/
12		final class ArrayParser
13		{
14		/**
15		* Convert an array from PostgresSQL to PHP.
16		*
17		* @param string\|null $value String to convert.
18		*/
19	11	public function parse(string\|null $value): array\|null
20		{
21	11	return $value !== null && $value[0] === '{'
22	11	? $this->parseArray($value)
23	11	: null;
24		}
25
26		/**
27		* Parse PostgreSQL array encoded in string.
28		*
29		* @param string $value String to parse.
30		* @param int $i parse starting position.
31		*/
32	11	private function parseArray(string $value, int &$i = 0): array
33		{
34	11	if ($value[++$i] === '}') {
35	1	++$i;
36	1	return [];
37		}
38
39	11	for ($result = [];; ++$i) {
40	11	$result[] = match ($value[$i]) {
41	11	'{' => $this->parseArray($value, $i),
42	11	',', '}' => null,
43	11	'"' => $this->parseQuotedString($value, $i),
44	11	default => $this->parseUnquotedString($value, $i),
45	11	};
46
47	11	if ($value[$i] === '}') {
48	11	++$i;
49	11	return $result;
50		}
51		}
		0 ignored issues – show Bug Best Practice introduced 2023-07-08 05:19 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `array`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
52		}
53
54		/**
55		* Parses quoted string.
56		*/
57	2	private function parseQuotedString(string $value, int &$i): string
58		{
59	2	for ($result = '', ++$i;; ++$i) {
60	2	if ($value[$i] === '\\') {
61	2	++$i;
62	2	} elseif ($value[$i] === '"') {
63	2	++$i;
64	2	return $result;
65		}
66
67	2	$result .= $value[$i];
68		}
		0 ignored issues – show Bug Best Practice introduced 2023-07-08 05:19 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `string`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
69		}
70
71		/**
72		* Parses unquoted string.
73		*/
74	11	private function parseUnquotedString(string $value, int &$i): string\|null
75		{
76	11	for ($result = '';; ++$i) {
77	11	if (in_array($value[$i], [',', '}'], true)) {
78	11	return $result !== 'NULL'
79	11	? $result
80	11	: null;
81		}
82
83	11	$result .= $value[$i];
84		}
85		}
86		}
87

yiisoft / db-pgsql

Push — dependabot/composer/rector/rec... ( 76b5ef...614a52 )

ArrayParser::parseUnquotedString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like