CommandPDOPgsql::internalExecute() - Code Metrics - Inspection of "Removing getDriver from ConnectionPDO classes" - yiisoft/db-pgsql - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — dev (#113)

by Def

created 2022-04-16 09:23 UTC

CommandPDOPgsql::internalExecute() B

↳ Parent: CommandPDOPgsql

Complexity

Conditions	9
Paths	9

Size

Total Lines	25
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	9.9957

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	9
eloc	18
c	1
b	0
f	0
nc	9
nop	1
dl	0
loc	25
ccs	10
cts	13
cp	0.7692
crap	9.9957
rs	8.0555

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Pgsql\PDO;

use Yiisoft\Db\Command\CommandPDO;
use Yiisoft\Db\Exception\ConvertException;
use Yiisoft\Db\Query\QueryBuilderInterface;
filter:
    dependency_paths: ["lib/*"]

final class CommandPDOPgsql extends CommandPDO
{
    /**
     * @inheritDoc
     */
    public function insertEx(string $table, array $columns): bool|array
    {
        $params = [];
        $sql = $this->queryBuilder()->insertEx($table, $columns, $params);

        $this->setSql($sql)->bindValues($params);
        $this->prepare(false);

        /** @var mixed */
        $queryOne = $this->queryOne();

        return is_array($queryOne) ? $queryOne : false;
    }

    public function queryBuilder(): QueryBuilderInterface
    {
        return $this->db->getQueryBuilder();
    }

    protected function internalExecute(?string $rawSql): void
    {
        $attempt = 0;

        while (true) {
            try {
                if (
                    ++$attempt === 1
                    && $this->isolationLevel !== null
                    && $this->db->getTransaction() === null
                ) {
                    $this->db->transaction(
                        fn (?string $rawSql): ?string => $this->internalExecute($rawSql),
                        $this->isolationLevel
                    );
                } else {
                    $this->pdoStatement?->execute();
                }
                break;
            } catch (\Exception $e) {
                $rawSql = $rawSql ?: $this->getRawSql();
                $e = (new ConvertException($e, $rawSql))->run();

                if ($this->retryHandler === null || !($this->retryHandler)($e, $attempt)) {
                    throw $e;
                }
            }
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Db\Pgsql\PDO;
6
7		use Yiisoft\Db\Command\CommandPDO;
8		use Yiisoft\Db\Exception\ConvertException;
9		use Yiisoft\Db\Query\QueryBuilderInterface;
		0 ignored issues – show Bug introduced 2022-02-12 12:43 UTC by Report Bug Copy Issue Report The type `Yiisoft\Db\Query\QueryBuilderInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
10
11		final class CommandPDOPgsql extends CommandPDO
12		{
13		/**
14		* @inheritDoc
15		*/
16	1	public function insertEx(string $table, array $columns): bool\|array
17		{
18	1	$params = [];
19	1	$sql = $this->queryBuilder()->insertEx($table, $columns, $params);
20
21	1	$this->setSql($sql)->bindValues($params);
22	1	$this->prepare(false);
23
24		/** @var mixed */
25	1	$queryOne = $this->queryOne();
26
27	1	return is_array($queryOne) ? $queryOne : false;
28		}
29
30	196	public function queryBuilder(): QueryBuilderInterface
31		{
32	196	return $this->db->getQueryBuilder();
33		}
34
35	176	protected function internalExecute(?string $rawSql): void
36		{
37		$attempt = 0;
38	176
39		while (true) {
40	176	try {
41	176	if (
42		++$attempt === 1
43		&& $this->isolationLevel !== null
44		&& $this->db->getTransaction() === null
45		) {
46	185	$this->db->transaction(
47		fn (?string $rawSql): ?string => $this->internalExecute($rawSql),
48	185	$this->isolationLevel
49		);
50	185	} else {
51		$this->pdoStatement?->execute();
52		}
53	185	break;
54	185	} catch (\Exception $e) {
55	185	$rawSql = $rawSql ?: $this->getRawSql();
56		$e = (new ConvertException($e, $rawSql))->run();
57
58		if ($this->retryHandler === null \|\| !($this->retryHandler)($e, $attempt)) {
59		throw $e;
60		}
61		}
62	185	}
63		}
64		}
65

yiisoft / db-pgsql

Pull Request — dev (#113)

CommandPDOPgsql::internalExecute() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like