DDLQueryBuilder::dropIndex() - Code Metrics - Inspection of "QueryBuilder refactoring" - yiisoft/db-oracle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — dev (#69)

by Def

created 2022-05-03 20:11 UTC

DDLQueryBuilder::dropIndex() A

↳ Parent: DDLQueryBuilder

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
c	0
b	0
f	0
nc	1
nop	2
dl	0
loc	3
rs	10
ccs	0
cts	0
cp	0
crap	2

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Oracle;

use Yiisoft\Db\Exception\Exception;
use Yiisoft\Db\Exception\NotSupportedException;
use Yiisoft\Db\Query\DDLQueryBuilder as AbstractDDLQueryBuilder;
use Yiisoft\Db\Query\QueryBuilderInterface;
filter:
    dependency_paths: ["lib/*"]
use Yiisoft\Db\Schema\ColumnSchemaBuilder;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

final class DDLQueryBuilder extends AbstractDDLQueryBuilder
{
    public function __construct(private QueryBuilderInterface $queryBuilder)
    {
        parent::__construct($queryBuilder);
    }

    public function addForeignKey(string $name, string $table, array|string $columns, string $refTable, array|string $refColumns, ?string $delete = null, ?string $update = null): string
    {
        $sql = 'ALTER TABLE ' . $this->quoter->quoteTableName($table)

            . ' ADD CONSTRAINT ' . $this->quoter->quoteColumnName($name)
            . ' FOREIGN KEY (' . $this->queryBuilder->buildColumns($columns) . ')'
            . ' REFERENCES ' . $this->quoter->quoteTableName($refTable)
            . ' (' . $this->queryBuilder->buildColumns($refColumns) . ')';

        if ($delete !== null) {
            $sql .= ' ON DELETE ' . $delete;
        }

        if ($update !== null) {
            throw new Exception('Oracle does not support ON UPDATE clause.');
        }

        return $sql;
    }

    public function alterColumn(string $table, string $column, ColumnSchemaBuilder|string $type): string
    {
        return 'ALTER TABLE '
            . $this->quoter->quoteTableName($table)

            . ' MODIFY '
            . $this->quoter->quoteColumnName($column)
            . ' ' . $this->queryBuilder->getColumnType($type);
    }

    public function checkIntegrity(string $schema = '', string $table = '', bool $check = true): string
    {
        throw new NotSupportedException('Oracle does not support enabling/disabling integrity check.');
    }

    public function dropCommentFromColumn(string $table, string $column): string
    {
        return 'COMMENT ON COLUMN '
            . $this->quoter->quoteTableName($table)

            . '.'
            . $this->quoter->quoteColumnName($column)
            . " IS ''";
    }

    public function dropCommentFromTable(string $table): string
    {
        return 'COMMENT ON TABLE ' . $this->quoter->quoteTableName($table) . " IS ''";

    }

    public function dropIndex(string $name, string $table): string
    {
        return 'DROP INDEX ' . $this->quoter->quoteTableName($name);

    }

    public function renameTable(string $oldName, string $newName): string
    {
        return 'ALTER TABLE ' . $this->quoter->quoteTableName($oldName) . ' RENAME TO ' .

            $this->quoter->quoteTableName($newName);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Db\Oracle;
6
7		use Yiisoft\Db\Exception\Exception;
8		use Yiisoft\Db\Exception\NotSupportedException;
9		use Yiisoft\Db\Query\DDLQueryBuilder as AbstractDDLQueryBuilder;
10		use Yiisoft\Db\Query\QueryBuilderInterface;
		0 ignored issues – show Bug introduced 2022-02-12 12:31 UTC by Report Bug Copy Issue Report The type `Yiisoft\Db\Query\QueryBuilderInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11		use Yiisoft\Db\Schema\ColumnSchemaBuilder;
		0 ignored issues – show Bug introduced 2022-05-03 20:20 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Yiisoft\Db\Oracle\ColumnSchemaBuilder`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
12	344
13		final class DDLQueryBuilder extends AbstractDDLQueryBuilder
14	344	{
15		public function __construct(private QueryBuilderInterface $queryBuilder)
16		{
17	2	parent::__construct($queryBuilder);
18		}
19
20	2	public function addForeignKey(string $name, string $table, array\|string $columns, string $refTable, array\|string $refColumns, ?string $delete = null, ?string $update = null): string
21		{
22	2	$sql = 'ALTER TABLE ' . $this->quoter->quoteTableName($table)
		0 ignored issues – show Bug Best Practice introduced 2022-05-03 20:20 UTC by Report Bug Copy Issue Report The property `quoter` does not exist on `Yiisoft\Db\Oracle\DDLQueryBuilder`. Did you maybe forget to declare it? Loading history...
23		. ' ADD CONSTRAINT ' . $this->quoter->quoteColumnName($name)
24		. ' FOREIGN KEY (' . $this->queryBuilder->buildColumns($columns) . ')'
25		. ' REFERENCES ' . $this->quoter->quoteTableName($refTable)
26	1	. ' (' . $this->queryBuilder->buildColumns($refColumns) . ')';
27
28	1	if ($delete !== null) {
29		$sql .= ' ON DELETE ' . $delete;
30		}
31
32		if ($update !== null) {
33		throw new Exception('Oracle does not support ON UPDATE clause.');
34		}
35
36		return $sql;
37		}
38
39		public function alterColumn(string $table, string $column, ColumnSchemaBuilder\|string $type): string
40		{
41		return 'ALTER TABLE '
42		. $this->quoter->quoteTableName($table)
		0 ignored issues – show Bug Best Practice introduced 2022-05-03 20:20 UTC by Report Bug Copy Issue Report The property `quoter` does not exist on `Yiisoft\Db\Oracle\DDLQueryBuilder`. Did you maybe forget to declare it? Loading history...
43		. ' MODIFY '
44		. $this->quoter->quoteColumnName($column)
45		. ' ' . $this->queryBuilder->getColumnType($type);
46		}
47
48		public function checkIntegrity(string $schema = '', string $table = '', bool $check = true): string
49		{
50		throw new NotSupportedException('Oracle does not support enabling/disabling integrity check.');
51		}
52
53		public function dropCommentFromColumn(string $table, string $column): string
54		{
55		return 'COMMENT ON COLUMN '
56		. $this->quoter->quoteTableName($table)
		0 ignored issues – show Bug Best Practice introduced 2022-05-03 20:20 UTC by Report Bug Copy Issue Report The property `quoter` does not exist on `Yiisoft\Db\Oracle\DDLQueryBuilder`. Did you maybe forget to declare it? Loading history...
57		. '.'
58		. $this->quoter->quoteColumnName($column)
59		. " IS ''";
60		}
61
62		public function dropCommentFromTable(string $table): string
63		{
64		return 'COMMENT ON TABLE ' . $this->quoter->quoteTableName($table) . " IS ''";
		0 ignored issues – show Bug Best Practice introduced 2022-05-03 20:20 UTC by Report Bug Copy Issue Report The property `quoter` does not exist on `Yiisoft\Db\Oracle\DDLQueryBuilder`. Did you maybe forget to declare it? Loading history...
65		}
66
67		public function dropIndex(string $name, string $table): string
68		{
69		return 'DROP INDEX ' . $this->quoter->quoteTableName($name);
		0 ignored issues – show Bug Best Practice introduced 2022-05-03 20:20 UTC by Report Bug Copy Issue Report The property `quoter` does not exist on `Yiisoft\Db\Oracle\DDLQueryBuilder`. Did you maybe forget to declare it? Loading history...
70		}
71
72		public function renameTable(string $oldName, string $newName): string
73		{
74		return 'ALTER TABLE ' . $this->quoter->quoteTableName($oldName) . ' RENAME TO ' .
		0 ignored issues – show Bug Best Practice introduced 2022-05-03 20:20 UTC by Report Bug Copy Issue Report The property `quoter` does not exist on `Yiisoft\Db\Oracle\DDLQueryBuilder`. Did you maybe forget to declare it? Loading history...
75		$this->quoter->quoteTableName($newName);
76		}
77		}
78

yiisoft / db-oracle

Pull Request — dev (#69)

DDLQueryBuilder::dropIndex() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like