CommandPDOMssql::internalExecute() - Code Metrics - Inspection of "Removing getDriver from ConnectionPDO classes" - yiisoft/db-mssql - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — dev (#82)

by Def

created 2022-04-16 09:23 UTC

CommandPDOMssql::internalExecute() B

↳ Parent: CommandPDOMssql

Complexity

Conditions	9
Paths	9

Size

Total Lines	25
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	9.9957

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	9
eloc	18
c	1
b	0
f	0
nc	9
nop	1
dl	0
loc	25
ccs	10
cts	13
cp	0.7692
crap	9.9957
rs	8.0555

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Mssql\PDO;

use PDOException;
use Yiisoft\Db\Command\CommandPDO;
use Yiisoft\Db\Exception\ConvertException;
use Yiisoft\Db\Query\QueryBuilderInterface;
filter:
    dependency_paths: ["lib/*"]

use function is_array;

final class CommandPDOMssql extends CommandPDO
{
    /**
     * @inheritDoc
    */
    public function insertEx(string $table, array $columns): bool|array
    {
        $params = [];
        $sql = $this->queryBuilder()->insertEx($table, $columns, $params);

        $this->setSql($sql)->bindValues($params);
        $this->prepare(false);

        /** @psalm-var array|bool */
        $result = $this->queryOne();

        return is_array($result) ? $result : false;
    }

    public function queryBuilder(): QueryBuilderInterface
    {
        return $this->db->getQueryBuilder();
    }

    protected function internalExecute(?string $rawSql): void
    {
        $attempt = 0;

        while (true) {
            try {
                if (
                    ++$attempt === 1
                    && $this->isolationLevel !== null
                    && $this->db->getTransaction() === null
                ) {
                    $this->db->transaction(
                        fn (string $rawSql) => $this->internalExecute($rawSql),
                        $this->isolationLevel
                    );
                } else {
                    $this->pdoStatement?->execute();
                }
                break;
            } catch (PDOException $e) {
                $rawSql = $rawSql ?: $this->getRawSql();
                $e = (new ConvertException($e, $rawSql))->run();

                if ($this->retryHandler === null || !($this->retryHandler)($e, $attempt)) {
                    throw $e;
                }
            }
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Db\Mssql\PDO;
6
7		use PDOException;
8		use Yiisoft\Db\Command\CommandPDO;
9		use Yiisoft\Db\Exception\ConvertException;
10		use Yiisoft\Db\Query\QueryBuilderInterface;
		0 ignored issues – show Bug introduced 2022-02-12 12:16 UTC by Report Bug Copy Issue Report The type `Yiisoft\Db\Query\QueryBuilderInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11
12		use function is_array;
13
14		final class CommandPDOMssql extends CommandPDO
15		{
16		/**
17		* @inheritDoc
18		*/
19	2	public function insertEx(string $table, array $columns): bool\|array
20		{
21	2	$params = [];
22	2	$sql = $this->queryBuilder()->insertEx($table, $columns, $params);
23
24	2	$this->setSql($sql)->bindValues($params);
25	2	$this->prepare(false);
26
27		/** @psalm-var array\|bool */
28	2	$result = $this->queryOne();
29
30	2	return is_array($result) ? $result : false;
31		}
32
33	214	public function queryBuilder(): QueryBuilderInterface
34		{
35	214	return $this->db->getQueryBuilder();
36		}
37
38	194	protected function internalExecute(?string $rawSql): void
39		{
40		$attempt = 0;
41	194
42		while (true) {
43	194	try {
44	194	if (
45		++$attempt === 1
46		&& $this->isolationLevel !== null
47		&& $this->db->getTransaction() === null
48		) {
49	203	$this->db->transaction(
50		fn (string $rawSql) => $this->internalExecute($rawSql),
51	203	$this->isolationLevel
52		);
53	203	} else {
54		$this->pdoStatement?->execute();
55		}
56	203	break;
57	203	} catch (PDOException $e) {
58	203	$rawSql = $rawSql ?: $this->getRawSql();
59		$e = (new ConvertException($e, $rawSql))->run();
60
61		if ($this->retryHandler === null \|\| !($this->retryHandler)($e, $attempt)) {
62		throw $e;
63		}
64		}
65	203	}
66		}
67		}
68

yiisoft / db-mssql

Pull Request — dev (#82)

CommandPDOMssql::internalExecute() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like