InConditionBuilder::buildCompositeInCondition() - Code Metrics - Inspection of "Fix `query/conditions`." - yiisoft/db-mssql - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — dev (#71)

by Wilmer

created 2022-02-23 22:04 UTC

InConditionBuilder::buildCompositeInCondition() B

↳ Parent: InConditionBuilder

Complexity

Conditions	10
Paths	18

Size

Total Lines	31
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	15
nc	18
nop	4
dl	0
loc	31
rs	7.6666
c	0
b	0
f	0

How to fix Complexity

<?php

declare(strict_types=1);

namespace Yiisoft\Db\Mssql\Builder;

use Traversable;
use Yiisoft\Db\Exception\Exception;
use Yiisoft\Db\Exception\InvalidArgumentException;
use Yiisoft\Db\Exception\InvalidConfigException;
use Yiisoft\Db\Exception\NotSupportedException;
use Yiisoft\Db\Expression\ExpressionInterface;
use Yiisoft\Db\Query\Conditions\Builder\InConditionBuilder as AbstractInConditionBuilder;
filter:
    dependency_paths: ["lib/*"]
use Yiisoft\Db\Query\QueryBuilderInterface;
filter:
    dependency_paths: ["lib/*"]

use function implode;
use function is_array;
use function strpos;

final class InConditionBuilder extends AbstractInConditionBuilder
{
    public function __construct(private QueryBuilderInterface $queryBuilder)
    {
        parent::__construct($queryBuilder);
    }

    /**
     * Builds SQL for IN condition.
     *
     * @param string $operator
     * @param array|string $columns
     * @param ExpressionInterface $values
     * @param array $params
     *
     * @throws Exception|InvalidArgumentException|InvalidConfigException|NotSupportedException
     *
     * @return string SQL
     */
    protected function buildSubqueryInCondition(
        string $operator,
        array|string $columns,
        ExpressionInterface $values,
        array &$params = []
    ): string {
        if (is_array($columns)) {

            throw new NotSupportedException(__METHOD__ . ' is not supported by MSSQL.');
        }

        return parent::buildSubqueryInCondition($operator, $columns, $values, $params);
    }

    /**
     * Builds SQL for IN condition.
     *
     * @param string|null $operator
     * @param array|Traversable $columns
     * @param array $values
     * @param array $params
     *
     * @return string SQL
     */
    protected function buildCompositeInCondition(
        ?string $operator,
        array|Traversable $columns,
        array|Traversable $values,
        array &$params = []
    ): string {
        $quotedColumns = [];

        /** @psalm-var string[] $columns */
        foreach ($columns as $i => $column) {
            $quotedColumns[$i] = strpos($column, '(') === false
                ? $this->queryBuilder->quoter()->quoteColumnName($column) : $column;
        }

        $vss = [];

        /** @psalm-var string[][] $values */
        foreach ($values as $value) {
            $vs = [];
            foreach ($columns as $i => $column) {
                if (isset($value[$column])) {
                    $phName = $this->queryBuilder->bindParam($value[$column], $params);
                    $vs[] = $quotedColumns[$i] . ($operator === 'IN' ? ' = ' : ' != ') . $phName;
                } else {
                    $vs[] = $quotedColumns[$i] . ($operator === 'IN' ? ' IS' : ' IS NOT') . ' NULL';
                }
            }
            $vss[] = '(' . implode($operator === 'IN' ? ' AND ' : ' OR ', $vs) . ')';
        }

        return '(' . implode($operator === 'IN' ? ' OR ' : ' AND ', $vss) . ')';
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Db\Mssql\Builder;
6
7			use Traversable;
8			use Yiisoft\Db\Exception\Exception;
9			use Yiisoft\Db\Exception\InvalidArgumentException;
10			use Yiisoft\Db\Exception\InvalidConfigException;
11			use Yiisoft\Db\Exception\NotSupportedException;
12			use Yiisoft\Db\Expression\ExpressionInterface;
13			use Yiisoft\Db\Query\Conditions\Builder\InConditionBuilder as AbstractInConditionBuilder;
			0 ignored issues – show Bug introduced 2022-02-23 22:07 UTC by Report Bug Copy Issue Report The type `Yiisoft\Db\Query\Conditi...lder\InConditionBuilder` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
14			use Yiisoft\Db\Query\QueryBuilderInterface;
			0 ignored issues – show Bug introduced 2022-02-12 12:16 UTC by Report Bug Copy Issue Report The type `Yiisoft\Db\Query\QueryBuilderInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
15
16			use function implode;
17			use function is_array;
18			use function strpos;
19
20			final class InConditionBuilder extends AbstractInConditionBuilder
21			{
22			public function __construct(private QueryBuilderInterface $queryBuilder)
23			{
24			parent::__construct($queryBuilder);
25			}
26
27			/**
28			* Builds SQL for IN condition.
29			*
30			* @param string $operator
31			* @param array\|string $columns
32			* @param ExpressionInterface $values
33			* @param array $params
34			*
35			* @throws Exception\|InvalidArgumentException\|InvalidConfigException\|NotSupportedException
36			*
37			* @return string SQL
38			*/
39			protected function buildSubqueryInCondition(
40			string $operator,
41			array\|string $columns,
42			ExpressionInterface $values,
43			array &$params = []
44			): string {
45			if (is_array($columns)) {
			0 ignored issues – show introduced 2022-02-16 12:21 UTC by Report Bug Copy Issue Report The condition `is_array($columns)` is always `true`. Loading history...
46			throw new NotSupportedException(__METHOD__ . ' is not supported by MSSQL.');
47			}
48
49			return parent::buildSubqueryInCondition($operator, $columns, $values, $params);
50			}
51
52			/**
53			* Builds SQL for IN condition.
54			*
55			* @param string\|null $operator
56			* @param array\|Traversable $columns
57			* @param array $values
58			* @param array $params
59			*
60			* @return string SQL
61			*/
62			protected function buildCompositeInCondition(
63			?string $operator,
64			array\|Traversable $columns,
65			array\|Traversable $values,
66			array &$params = []
67			): string {
68			$quotedColumns = [];
69
70			/** @psalm-var string[] $columns */
71			foreach ($columns as $i => $column) {
72			$quotedColumns[$i] = strpos($column, '(') === false
73			? $this->queryBuilder->quoter()->quoteColumnName($column) : $column;
74			}
75
76			$vss = [];
77
78			/** @psalm-var string[][] $values */
79			foreach ($values as $value) {
80			$vs = [];
81			foreach ($columns as $i => $column) {
82			if (isset($value[$column])) {
83			$phName = $this->queryBuilder->bindParam($value[$column], $params);
84			$vs[] = $quotedColumns[$i] . ($operator === 'IN' ? ' = ' : ' != ') . $phName;
85			} else {
86			$vs[] = $quotedColumns[$i] . ($operator === 'IN' ? ' IS' : ' IS NOT') . ' NULL';
87			}
88			}
89			$vss[] = '(' . implode($operator === 'IN' ? ' AND ' : ' OR ', $vs) . ')';
90			}
91
92			return '(' . implode($operator === 'IN' ? ' OR ' : ' AND ', $vss) . ')';
93			}
94			}
95

yiisoft / db-mssql

Pull Request — dev (#71)

InConditionBuilder::buildCompositeInCondition() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like