BetweenHandler::match() - Code Metrics - Inspection of "Simplify `FilterInterface` and `FilterHandlerInter..." - yiisoft/data - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#165)

by Sergei

created 2024-02-24 09:39 UTC

BetweenHandler::match() A

↳ Parent: BetweenHandler

Complexity

Conditions	6
Paths	6

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	6

Importance

Changes

Metric	Value
eloc	8
dl	0
loc	14
ccs	8
cts	8
cp	1
rs	9.2222
c	0
b	0
f	0
cc	6
nc	6
nop	3
crap	6

<?php

declare(strict_types=1);

namespace Yiisoft\Data\Reader\Iterable\FilterHandler;

use DateTimeInterface;
use InvalidArgumentException;
use Yiisoft\Arrays\ArrayHelper;
use Yiisoft\Data\Reader\Filter\Between;
use Yiisoft\Data\Reader\FilterInterface;
use Yiisoft\Data\Reader\Iterable\IterableFilterHandlerInterface;

/**
 * `Between` iterable filter handler checks that the item's field value
 * is between minimal and maximal values.
 */
final class BetweenHandler implements IterableFilterHandlerInterface
{
    public function getFilterClass(): string
    {
        return Between::class;
    }

    public function match(array|object $item, FilterInterface $filter, array $iterableFilterHandlers): bool
    {
        /** @var Between $filter */

        $value = ArrayHelper::getValue($item, $filter->field);

        if (!$value instanceof DateTimeInterface) {
            return $value >= $filter->minValue && $value <= $filter->maxValue;
        }

        return $filter->minValue instanceof DateTimeInterface
            && $filter->maxValue instanceof DateTimeInterface
            && $value->getTimestamp() >= $filter->minValue->getTimestamp()
            && $value->getTimestamp() <= $filter->maxValue->getTimestamp();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Data\Reader\Iterable\FilterHandler;
6
7		use DateTimeInterface;
8		use InvalidArgumentException;
9		use Yiisoft\Arrays\ArrayHelper;
10		use Yiisoft\Data\Reader\Filter\Between;
11		use Yiisoft\Data\Reader\FilterInterface;
12		use Yiisoft\Data\Reader\Iterable\IterableFilterHandlerInterface;
13
14		/**
15		* `Between` iterable filter handler checks that the item's field value
16		* is between minimal and maximal values.
17		*/
18		final class BetweenHandler implements IterableFilterHandlerInterface
19		{
20	143	public function getFilterClass(): string
21		{
22	143	return Between::class;
23		}
24
25	11	public function match(array\|object $item, FilterInterface $filter, array $iterableFilterHandlers): bool
26		{
27		/** @var Between $filter */
28
29	11	$value = ArrayHelper::getValue($item, $filter->field);
30
31	11	if (!$value instanceof DateTimeInterface) {
32	6	return $value >= $filter->minValue && $value <= $filter->maxValue;
33		}
34
35	5	return $filter->minValue instanceof DateTimeInterface
36	5	&& $filter->maxValue instanceof DateTimeInterface
37	5	&& $value->getTimestamp() >= $filter->minValue->getTimestamp()
38	5	&& $value->getTimestamp() <= $filter->maxValue->getTimestamp();
39		}
40		}
41

yiisoft / data

Pull Request — master (#165)

BetweenHandler::match() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like